You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Bhargavkonidena (via GitHub)" <gi...@apache.org> on 2025/12/15 04:27:29 UTC

[PR] Fix issue 14830 [iceberg]

Bhargavkonidena opened a new pull request, #14848:
URL: https://github.com/apache/iceberg/pull/14848

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix LICENSE for iceberg-azure's transitive deps [iceberg]

Posted by "Bhargavkonidena (via GitHub)" <gi...@apache.org>.
Bhargavkonidena commented on PR #14848:
URL: https://github.com/apache/iceberg/pull/14848#issuecomment-3704369559

   > That's not fully correct as MIT/BSD license text should be inline.
   > 
   > Happy to help on this one or create another one as I mentioned in my previous PR.
   
   Hi @jbonofre, I fixed the inline text by following your previous PR. Could you please check now once.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix issue 14830 [iceberg]

Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on code in PR #14848:
URL: https://github.com/apache/iceberg/pull/14848#discussion_r2621502403


##########
flink/v1.20/flink-runtime/LICENSE:
##########
@@ -453,6 +453,12 @@ License: https://www.apache.org/licenses/LICENSE-2.0.html
 
 --------------------------------------------------------------------------------
 
+Group: com.azure  Name: azure-security-keyvault-keys  Version: 4.10.2
+Project URL: https://github.com/Azure/azure-sdk-for-java
+License: The MIT License (MIT) - http://opensource.org/licenses/MIT

Review Comment:
   To be consistent with the existing entries, can we use something like 
   ```
   This binary artifact contains …
   Copyright …
   Home page …
   License …
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix LICENSE for iceberg-azure's transitive deps [iceberg]

Posted by "Bhargavkonidena (via GitHub)" <gi...@apache.org>.
Bhargavkonidena commented on PR #14848:
URL: https://github.com/apache/iceberg/pull/14848#issuecomment-4238304257

   @jbonofre @kevinjqliu @huaxingao   I have fixed based on your suggestions, let me know once reviewed. Want to check if any more changes needed on this. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix LICENSE for iceberg-azure's transitive deps [iceberg]

Posted by "Bhargavkonidena (via GitHub)" <gi...@apache.org>.
Bhargavkonidena commented on PR #14848:
URL: https://github.com/apache/iceberg/pull/14848#issuecomment-4051357117

   @jbonofre @kevinjqliu @huaxingao I have fixed it as per suggestions. can you review this MR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix LICENSE for iceberg-azure's transitive deps [iceberg]

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #14848:
URL: https://github.com/apache/iceberg/pull/14848#issuecomment-3690241546

   That's not fully correct as MIT/BSD license text should be inline. 
   
   Happy to help on this one or create another one as I mentioned in my previous PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix LICENSE for iceberg-azure's transitive deps [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14848:
URL: https://github.com/apache/iceberg/pull/14848#issuecomment-4233102429

   This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix LICENSE for iceberg-azure's transitive deps [iceberg]

Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on PR #14848:
URL: https://github.com/apache/iceberg/pull/14848#issuecomment-3658405559

   cc @jbonofre @kevinjqliu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix LICENSE for iceberg-azure's transitive deps [iceberg]

Posted by "Bhargavkonidena (via GitHub)" <gi...@apache.org>.
Bhargavkonidena commented on PR #14848:
URL: https://github.com/apache/iceberg/pull/14848#issuecomment-3690236837

   @jbonofre @kevinjqliu @huaxingao can you please review the fixes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix LICENSE for iceberg-azure's transitive deps [iceberg]

Posted by "Bhargavkonidena (via GitHub)" <gi...@apache.org>.
Bhargavkonidena commented on PR #14848:
URL: https://github.com/apache/iceberg/pull/14848#issuecomment-4233133437

   @jbonofre @kevinjqliu @huaxingao I have fixed it as per suggestions. can you review this MR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix LICENSE for iceberg-azure's transitive deps [iceberg]

Posted by "Bhargavkonidena (via GitHub)" <gi...@apache.org>.
Bhargavkonidena commented on PR #14848:
URL: https://github.com/apache/iceberg/pull/14848#issuecomment-3818910363

   @jbonofre  can you validate it now?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix LICENSE for iceberg-azure's transitive deps [iceberg]

Posted by "ns-cbalasaiharika (via GitHub)" <gi...@apache.org>.
ns-cbalasaiharika commented on code in PR #14848:
URL: https://github.com/apache/iceberg/pull/14848#discussion_r2644666992


##########
flink/v1.20/flink-runtime/LICENSE:
##########
@@ -453,6 +453,12 @@ License: https://www.apache.org/licenses/LICENSE-2.0.html
 
 --------------------------------------------------------------------------------
 
+Group: com.azure  Name: azure-security-keyvault-keys  Version: 4.10.2
+Project URL: https://github.com/Azure/azure-sdk-for-java
+License: The MIT License (MIT) - http://opensource.org/licenses/MIT

Review Comment:
   Done



##########
flink/v1.20/flink-runtime/LICENSE:
##########
@@ -453,6 +453,12 @@ License: https://www.apache.org/licenses/LICENSE-2.0.html
 
 --------------------------------------------------------------------------------
 
+Group: com.azure  Name: azure-security-keyvault-keys  Version: 4.10.2
+Project URL: https://github.com/Azure/azure-sdk-for-java
+License: The MIT License (MIT) - http://opensource.org/licenses/MIT

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix LICENSE for iceberg-azure's transitive deps [iceberg]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu closed pull request #14848: Fix LICENSE for iceberg-azure's transitive deps
URL: https://github.com/apache/iceberg/pull/14848


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix LICENSE for iceberg-azure's transitive deps [iceberg]

Posted by "mxm (via GitHub)" <gi...@apache.org>.
mxm commented on code in PR #14848:
URL: https://github.com/apache/iceberg/pull/14848#discussion_r3079540114


##########
flink/v2.1/flink-runtime/LICENSE:
##########
@@ -614,6 +614,35 @@ License: BSD 2-Clause
 
 --------------------------------------------------------------------------------
 
+This binary artifact contains Azure Security Key Vault Keys.

Review Comment:
   `azure-security-keyvault-keys` is `compileOnly` in `iceberg-azure`: https://github.com/apache/iceberg/blob/87c743463b6311f2412e1addf19cf204c1b79e3d/build.gradle#L599 Thus, it should not end up on the runtime classpath which is the basis for the shadow jar built in `flink-runtime`.
   
   You can verify with:
   ```
   ./gradlew :iceberg-flink:iceberg-flink-runtime-2.1:dependencies --configuration runtimeClasspath
   ```
   
   The library is only bundled in `iceberg-azure-bundle`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix LICENSE for iceberg-azure's transitive deps [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14848:
URL: https://github.com/apache/iceberg/pull/14848#issuecomment-4051299874

   This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix LICENSE for iceberg-azure's transitive deps [iceberg]

Posted by "Bhargavkonidena (via GitHub)" <gi...@apache.org>.
Bhargavkonidena commented on PR #14848:
URL: https://github.com/apache/iceberg/pull/14848#issuecomment-3875175597

   @jbonofre @kevinjqliu @huaxingao I have fixed it as per suggestions. can you review this MR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Fix LICENSE for iceberg-azure's transitive deps [iceberg]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #14848:
URL: https://github.com/apache/iceberg/pull/14848#issuecomment-4392495122

   superseded by #16181


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org