You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ariatosca.apache.org by dankilman <gi...@git.apache.org> on 2016/10/20 12:24:20 UTC

[GitHub] incubator-ariatosca pull request #9: pylint tests

GitHub user dankilman opened a pull request:

    https://github.com/apache/incubator-ariatosca/pull/9

    pylint tests

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-ariatosca pylint-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-ariatosca/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9
    
----
commit 88a077883d3208fd248ed65d6c338e483e49ae36
Author: Dan Kilman <da...@gmail.com>
Date:   2016-10-20T12:22:45Z

    pylint tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #9: pylint tests

Posted by dankilman <gi...@git.apache.org>.

Github user dankilman commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/9#discussion_r84275787
  
    --- Diff: tests/workflows/test_executor.py ---
    @@ -21,11 +21,12 @@
     
     from aria import events
     from aria.storage import models
    -from aria.workflows.core import executor
     
     
     class TestExecutor(object):
     
    +    executor = None
    --- End diff --
    
    remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #9: pylint tests

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-ariatosca/pull/9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #9: pylint tests

Posted by dankilman <gi...@git.apache.org>.

Github user dankilman commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/9#discussion_r84275228
  
    --- Diff: tests/storage/test_drivers.py ---
    @@ -83,10 +83,10 @@ def test_custom_driver():
     
     
     class TestFileSystemDriver(TestFileSystem):
    +    driver = None
    --- End diff --
    
    remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #9: pylint tests

Posted by dankilman <gi...@git.apache.org>.

Github user dankilman commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/9#discussion_r84275191
  
    --- Diff: tests/storage/__init__.py ---
    @@ -45,9 +45,12 @@ def update(self, name, entry_id, **kwargs):
     
     
     class TestFileSystem(object):
    -    def setup_method(self, method):
    +
    +    path = None
    --- End diff --
    
    remove and add rule


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---