You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by le...@apache.org on 2019/06/17 17:40:54 UTC

[incubator-datasketches-memory] branch directoryMoves created (now 4f86fe1)

This is an automated email from the ASF dual-hosted git repository.

leerho pushed a change to branch directoryMoves
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-memory.git.


      at 4f86fe1  Update FindBugs Exclude Filter in tools/

This branch includes the following new commits:

     new 4f86fe1  Update FindBugs Exclude Filter in tools/

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


[incubator-datasketches-memory] 01/01: Update FindBugs Exclude Filter in tools/

Posted by le...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

leerho pushed a commit to branch directoryMoves
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-memory.git

commit 4f86fe1c18443c5402e09584c8e4e54b41585450
Author: Lee Rhodes <le...@users.noreply.github.com>
AuthorDate: Mon Jun 17 10:40:45 2019 -0700

    Update FindBugs Exclude Filter in tools/
---
 tools/FindBugsExcludeFilter.xml | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/tools/FindBugsExcludeFilter.xml b/tools/FindBugsExcludeFilter.xml
index 16e5fa3..115d3e4 100644
--- a/tools/FindBugsExcludeFilter.xml
+++ b/tools/FindBugsExcludeFilter.xml
@@ -1,25 +1,10 @@
-<FindBugsFilter> <!-- sketches-core -->
+<FindBugsFilter> <!-- memory -->
 
   <!-- Too many false positives to be useful.  I could not make it happy :( -->
   <Match>
     <Bug pattern="SF_SWITCH_NO_DEFAULT" />
   </Match>
 
-  <!-- False positive.  FindBugs complains if DQS_RESIZE_THRESHOLD == REBUILD_THRESHOLD, 
-       but this allows us to tune these constants for different sketches. -->
-  <Match>
-    <Bug pattern="DB_DUPLICATE_BRANCHES" />
-    <Class name="com.yahoo.sketches.theta.DirectQuickSelectSketch" />
-    <Method name="setHashTableThreshold" />
-  </Match>
-
-  <!-- False positive.  In this case we want to ignore the exceptions -->
-  <Match>
-    <Bug pattern="DE_MIGHT_IGNORE" />
-    <Class name="com.yahoo.sketches.theta.PairwiseCornerCasesTest" />
-    <Method name="checkNotOrdered" />
-  </Match>
-  
   <Match>   <!-- Exclude for test classes; too many False Positives. -->
     <Bug pattern="NP_NULL_PARAM_DEREF_NONVIRTUAL" />
     <Class name="~.*\.*Test" />


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org