[jira] [Resolved] (HTTPCLIENT-1656) Client Builder doesn't expose setValidateAfterInactivity(int)

["Oleg Kalnichevski (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-1656.
-------------------------------------------
    Resolution: Fixed

#setValidateAfterInactivity method is now available in {{PoolingHttpClientConnectionManagerBuilder}} class. 

All connection pool initialization logic moved from {{HttpClientBuilder}} / {{HttpAsyncClientBuilder}} to {{PoolingHttpClientConnectionManagerBuilder}} / {{PoolingAsyncClientConnectionManagerBuilder}}

https://github.com/apache/httpclient/blob/trunk/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManagerBuilder.java
https://github.com/apache/httpclient/blob/trunk/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManagerBuilder.java

> Client Builder doesn't expose setValidateAfterInactivity(int)
> -------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1656
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1656
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient (classic)
>    Affects Versions: 4.4.1
>            Reporter: yair ogen
>            Assignee: Oleg Kalnichevski
>            Priority: Minor
>             Fix For: 5.0 Alpha2
>
>
> The API 'setStaleConnectionCheckEnabled' on the RequestConfig Builder is deprecated. It points to calling 'setValidateAfterInactivity' on the PoolingHttpClientConnectionManager class. 
> However we shouldn't mandate creating our own PoolingHttpClientConnectionManager instance (instead of reusing the one created automatically by the httpClient builder) just to setValidateAfterInactivity.
> We should expose on the client/request config builder a setValidateAfterInactivity like we do for 'setMaxConnPerRoute' and 'setMaxConnTotal' (which in the builder are later set on the internally created PoolingHttpClientConnectionManager ).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org