You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/06/10 20:16:40 UTC

Review Request 22426: Changed MessageEvent and ExitedEvent to be copyable.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22426/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Bugs: MESOS-1444
    https://issues.apache.org/jira/browse/MESOS-1444


Repository: mesos-git


Description
-------

This is necessary for https://reviews.apache.org/r/22427, Master needs to bind these events as arguments when deferring them.


Diffs
-----

  3rdparty/libprocess/include/process/event.hpp e30a4d4aa7d8235bc3fb41a6ae1684b89d351679 

Diff: https://reviews.apache.org/r/22426/diff/


Testing
-------

Tested along with https://reviews.apache.org/r/22427


Thanks,

Jiang Yan Xu

Re: Review Request 22426: Changed MessageEvent and ExitedEvent to be copyable.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22426/#review45285
-----------------------------------------------------------


also make sure to set "depends on" appropriately.

- Vinod Kone


On June 10, 2014, 6:16 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22426/
> -----------------------------------------------------------
> 
> (Updated June 10, 2014, 6:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1444
>     https://issues.apache.org/jira/browse/MESOS-1444
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is necessary for https://reviews.apache.org/r/22427, Master needs to bind these events as arguments when deferring them.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/event.hpp e30a4d4aa7d8235bc3fb41a6ae1684b89d351679 
> 
> Diff: https://reviews.apache.org/r/22426/diff/
> 
> 
> Testing
> -------
> 
> Tested along with https://reviews.apache.org/r/22427
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 22426: Changed MessageEvent and ExitedEvent to be copyable.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22426/#review45284
-----------------------------------------------------------



3rdparty/libprocess/include/process/event.hpp
<https://reviews.apache.org/r/22426/#comment80044>

    Is this safe? I'll let @benh take a look.


- Vinod Kone


On June 10, 2014, 6:16 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22426/
> -----------------------------------------------------------
> 
> (Updated June 10, 2014, 6:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1444
>     https://issues.apache.org/jira/browse/MESOS-1444
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is necessary for https://reviews.apache.org/r/22427, Master needs to bind these events as arguments when deferring them.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/event.hpp e30a4d4aa7d8235bc3fb41a6ae1684b89d351679 
> 
> Diff: https://reviews.apache.org/r/22426/diff/
> 
> 
> Testing
> -------
> 
> Tested along with https://reviews.apache.org/r/22427
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 22426: Changed MessageEvent and ExitedEvent to be copyable.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22426/
-----------------------------------------------------------

(Updated June 17, 2014, 2:01 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Changed these events to be not copy assignable to keep the fields const.


Bugs: MESOS-1444
    https://issues.apache.org/jira/browse/MESOS-1444


Repository: mesos-git


Description
-------

This is necessary for https://reviews.apache.org/r/22427, Master needs to bind these events as arguments when deferring them.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/event.hpp e30a4d4aa7d8235bc3fb41a6ae1684b89d351679 

Diff: https://reviews.apache.org/r/22426/diff/


Testing
-------

Tested along with https://reviews.apache.org/r/22427


Thanks,

Jiang Yan Xu

Re: Review Request 22426: Changed MessageEvent and ExitedEvent to be copyable.

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On June 17, 2014, 1:35 a.m., Vinod Kone wrote:
> > 3rdparty/libprocess/include/process/event.hpp, line 193
> > <https://reviews.apache.org/r/22426/diff/1/?file=606519#file606519line193>
> >
> >     why this change?
> 
> Jiang Yan Xu wrote:
>     Otherwise the implicitly-declared copy assignment operator is deleted. http://en.cppreference.com/w/cpp/language/as_operator#Deleted_implicitly-declared_copy_assignment_operator

Vinod makes a good point, we should leave a comment here that says something along the lines of "instance variable is not const so that struct is default copyable".


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22426/#review45882
-----------------------------------------------------------


On June 10, 2014, 6:16 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22426/
> -----------------------------------------------------------
> 
> (Updated June 10, 2014, 6:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1444
>     https://issues.apache.org/jira/browse/MESOS-1444
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is necessary for https://reviews.apache.org/r/22427, Master needs to bind these events as arguments when deferring them.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/event.hpp e30a4d4aa7d8235bc3fb41a6ae1684b89d351679 
> 
> Diff: https://reviews.apache.org/r/22426/diff/
> 
> 
> Testing
> -------
> 
> Tested along with https://reviews.apache.org/r/22427
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 22426: Changed MessageEvent and ExitedEvent to be copyable.

Posted by Jiang Yan Xu <ya...@jxu.me>.

> On June 16, 2014, 6:35 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/include/process/event.hpp, line 193
> > <https://reviews.apache.org/r/22426/diff/1/?file=606519#file606519line193>
> >
> >     why this change?

Otherwise the implicitly-declared copy assignment operator is deleted. http://en.cppreference.com/w/cpp/language/as_operator#Deleted_implicitly-declared_copy_assignment_operator


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22426/#review45882
-----------------------------------------------------------


On June 10, 2014, 11:16 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22426/
> -----------------------------------------------------------
> 
> (Updated June 10, 2014, 11:16 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1444
>     https://issues.apache.org/jira/browse/MESOS-1444
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is necessary for https://reviews.apache.org/r/22427, Master needs to bind these events as arguments when deferring them.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/event.hpp e30a4d4aa7d8235bc3fb41a6ae1684b89d351679 
> 
> Diff: https://reviews.apache.org/r/22426/diff/
> 
> 
> Testing
> -------
> 
> Tested along with https://reviews.apache.org/r/22427
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 22426: Changed MessageEvent and ExitedEvent to be copyable.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22426/#review45882
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/include/process/event.hpp
<https://reviews.apache.org/r/22426/#comment80958>

    why this change?


- Vinod Kone


On June 10, 2014, 6:16 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22426/
> -----------------------------------------------------------
> 
> (Updated June 10, 2014, 6:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1444
>     https://issues.apache.org/jira/browse/MESOS-1444
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is necessary for https://reviews.apache.org/r/22427, Master needs to bind these events as arguments when deferring them.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/event.hpp e30a4d4aa7d8235bc3fb41a6ae1684b89d351679 
> 
> Diff: https://reviews.apache.org/r/22426/diff/
> 
> 
> Testing
> -------
> 
> Tested along with https://reviews.apache.org/r/22427
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 22426: Changed MessageEvent and ExitedEvent to be copyable.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22426/#review45414
-----------------------------------------------------------


Patch looks great!

Reviews applied: [22426]

All tests passed.

- Mesos ReviewBot


On June 10, 2014, 6:16 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22426/
> -----------------------------------------------------------
> 
> (Updated June 10, 2014, 6:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1444
>     https://issues.apache.org/jira/browse/MESOS-1444
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is necessary for https://reviews.apache.org/r/22427, Master needs to bind these events as arguments when deferring them.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/event.hpp e30a4d4aa7d8235bc3fb41a6ae1684b89d351679 
> 
> Diff: https://reviews.apache.org/r/22426/diff/
> 
> 
> Testing
> -------
> 
> Tested along with https://reviews.apache.org/r/22427
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 22426: Changed MessageEvent and ExitedEvent to be copyable.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22426/#review45291
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On June 10, 2014, 6:16 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22426/
> -----------------------------------------------------------
> 
> (Updated June 10, 2014, 6:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1444
>     https://issues.apache.org/jira/browse/MESOS-1444
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is necessary for https://reviews.apache.org/r/22427, Master needs to bind these events as arguments when deferring them.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/event.hpp e30a4d4aa7d8235bc3fb41a6ae1684b89d351679 
> 
> Diff: https://reviews.apache.org/r/22426/diff/
> 
> 
> Testing
> -------
> 
> Tested along with https://reviews.apache.org/r/22427
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>