You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by AurelioDeRosa <gi...@git.apache.org> on 2014/07/22 17:06:42 UTC

[GitHub] cordova-plugin-media pull request: Update index.md

GitHub user AurelioDeRosa opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/23

    Update index.md

    As stated in the documentation, the successCallback is optional

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AurelioDeRosa/cordova-plugin-media patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit 3c2f4441e2b6a7238f97284a5a5c4af81b9c3f22
Author: Aurelio De Rosa <au...@gmail.com>
Date:   2014-07-22T15:06:33Z

    Update index.md
    
    As stated in the documentation, the successCallback is optional

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-media pull request: Update index.md

Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media/pull/23#discussion_r16177462
  
    --- Diff: doc/index.md ---
    @@ -49,7 +49,7 @@ and may deprecate the current APIs.
     
     ## Media
     
    -    var media = new Media(src, mediaSuccess, [mediaError], [mediaStatus]);
    --- End diff --
    
    Do we usually use this notation *in* JavaScript?
    
    In JavaScript, []s usually mean _an_ Array. For an example, I'd expect:
    ```js
    var media = new Media(src, mediaSuccess, mediaError, mediaStatus);
    ```
    
    Also, normally things should have a bug (issues.apache.org/jira) corresponding to the change...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-media pull request: Update index.md

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-media/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org