You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/23 06:31:02 UTC

[GitHub] [tvm] zhiics edited a comment on pull request #7564: [BYOC] Exclude external params from Graph Runtime

zhiics edited a comment on pull request #7564:
URL: https://github.com/apache/tvm/pull/7564#issuecomment-804654019


   The approach I was thinking is that we can probably use the `MetadataModule` as the only place to save the weights. Other modules including `GraphRuntimeModule` can directly query the needed parameters from it (external modules have done that).
   
   The way we filter the redundant parameters in the this PR can be used by users after the build (i.e. we can document it somewhere) but should not be part of the `build` codebase in my opinion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org