You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/02/08 21:58:03 UTC

[GitHub] rafaelweingartner commented on a change in pull request #3170: NotImplemented as a local exception

rafaelweingartner commented on a change in pull request #3170: NotImplemented as a local exception
URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255248770
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
 ##########
 @@ -72,7 +70,7 @@ public static PreallocationType getPreallocationType(final Storage.ProvisioningT
             case FAT:
                 return PreallocationType.Full;
             default:
-                throw new NotImplementedException();
+                throw new NotImplementedProvisioningTypeException();
 
 Review comment:
   What if instead, you throw a cloud runtime with a message describing the problem/error here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services