You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/05 19:37:17 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #19539: refactor: Removes the CSS files from the Parallel Coordinates plugin
michael-s-molina opened a new pull request, #19539:
URL: https://github.com/apache/superset/pull/19539
### SUMMARY
This PR removes the CSS files from the Parallel Coordinates plugin using Emotion. It also adjusts the styles to match theme configuration and existing components.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1134" alt="Screen Shot 2022-04-05 at 3 41 18 PM" src="https://user-images.githubusercontent.com/70410625/161835531-4043182d-6410-4494-8606-4d982a1955ce.png">
<img width="1133" alt="Screen Shot 2022-04-05 at 4 27 56 PM" src="https://user-images.githubusercontent.com/70410625/161835554-516e8f11-bcca-4e9c-8408-93147a802f7d.png">
### TESTING INSTRUCTIONS
Check that the plugin is very similar to the previous version. We may have color, font, and opacity differences due to theme adjustments.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19539: refactor: Removes the CSS files from the Parallel Coordinates plugin
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19539:
URL: https://github.com/apache/superset/pull/19539#issuecomment-1089295963
# [Codecov](https://codecov.io/gh/apache/superset/pull/19539?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19539](https://codecov.io/gh/apache/superset/pull/19539?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (daff568) into [master](https://codecov.io/gh/apache/superset/commit/1eef923b31005eaf13e4b068a939d0fb27716c90?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1eef923) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #19539 +/- ##
==========================================
- Coverage 66.60% 66.59% -0.01%
==========================================
Files 1678 1682 +4
Lines 64246 64302 +56
Branches 6539 6560 +21
==========================================
+ Hits 42788 42821 +33
- Misses 19763 19780 +17
- Partials 1695 1701 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.36% <0.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntend/packages/superset-ui-core/src/color/utils.ts](https://codecov.io/gh/apache/superset/pull/19539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvdXRpbHMudHM=) | `94.28% <0.00%> (-5.72%)` | :arrow_down: |
| [...rt-parallel-coordinates/src/ParallelCoordinates.js](https://codecov.io/gh/apache/superset/pull/19539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcmFsbGVsLWNvb3JkaW5hdGVzL3NyYy9QYXJhbGxlbENvb3JkaW5hdGVzLmpz) | `0.00% <ø> (ø)` | |
| [...allel-coordinates/src/ReactParallelCoordinates.jsx](https://codecov.io/gh/apache/superset/pull/19539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcmFsbGVsLWNvb3JkaW5hdGVzL3NyYy9SZWFjdFBhcmFsbGVsQ29vcmRpbmF0ZXMuanN4) | `0.00% <0.00%> (ø)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/19539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `41.07% <0.00%> (-8.93%)` | :arrow_down: |
| [.../explore/components/ExploreViewContainer/index.jsx](https://codecov.io/gh/apache/superset/pull/19539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci9pbmRleC5qc3g=) | `54.39% <0.00%> (-2.60%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/19539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `46.36% <0.00%> (-0.80%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/19539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/profile/App.tsx](https://codecov.io/gh/apache/superset/pull/19539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/components/FaveStar/index.tsx](https://codecov.io/gh/apache/superset/pull/19539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmF2ZVN0YXIvaW5kZXgudHN4) | `100.00% <0.00%> (ø)` | |
| [...plugins/legacy-plugin-chart-treemap/src/Treemap.js](https://codecov.io/gh/apache/superset/pull/19539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXRyZWVtYXAvc3JjL1RyZWVtYXAuanM=) | `0.00% <0.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/superset/pull/19539/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19539?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19539?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1eef923...daff568](https://codecov.io/gh/apache/superset/pull/19539?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a diff in pull request #19539: refactor: Removes the CSS files from the Parallel Coordinates plugin
Posted by GitBox <gi...@apache.org>.
geido commented on code in PR #19539:
URL: https://github.com/apache/superset/pull/19539#discussion_r843739398
##########
superset-frontend/plugins/legacy-plugin-chart-parallel-coordinates/src/ReactParallelCoordinates.jsx:
##########
@@ -34,14 +34,93 @@ ParallelCoordianes.propTypes = {
};
export default styled(ParallelCoordianes)`
- .superset-legacy-chart-parallel-coordinates {
- div.grid {
- overflow: auto;
- div.row {
- &:hover {
- background-color: ${({ theme }) => theme.colors.grayscale.light2};
+ ${({ theme }) => `
+ .superset-legacy-chart-parallel-coordinates {
+ div.grid {
+ overflow: auto;
+ div.row {
+ &:hover {
+ background-color: ${theme.colors.grayscale.light2};
+ }
}
}
}
- }
+ .parcoords svg,
+ .parcoords canvas {
+ font-size: ${theme.typography.sizes.s}px;
+ position: absolute;
+ }
+ .parcoords > canvas {
+ pointer-events: none;
+ }
+
+ .parcoords text.label {
+ font: 100%;
+ font-size: ${theme.typography.sizes.s}px;
+ cursor: drag;
+ }
+ .parcoords rect.background {
+ fill: transparent;
+ }
+ .parcoords rect.background:hover {
+ fill: ${addAlpha(theme.colors.grayscale.base, 0.2)};
+ }
+ .parcoords .resize rect {
+ fill: ${addAlpha(theme.colors.grayscale.dark2, 0.1)};
+ }
+ .parcoords rect.extent {
+ fill: ${addAlpha(theme.colors.grayscale.light5, 0.25)};
+ stroke: ${addAlpha(theme.colors.grayscale.dark2, 0.6)};
+ }
+ .parcoords .axis line,
+ .parcoords .axis path {
+ fill: none;
+ stroke: ${theme.colors.grayscale.dark1};
+ shape-rendering: crispEdges;
+ }
+ .parcoords canvas {
+ opacity: 1;
+ -moz-transition: opacity 0.3s;
+ -webkit-transition: opacity 0.3s;
+ -o-transition: opacity 0.3s;
+ }
+ .parcoords canvas.faded {
+ opacity: ${theme.opacity.mediumLight};
+ }
+ .parcoords {
+ -webkit-touch-callout: none;
+ -webkit-user-select: none;
+ -khtml-user-select: none;
+ -moz-user-select: none;
+ -ms-user-select: none;
+ user-select: none;
+ background-color: ${theme.colors.grayscale.light5};
+ }
+
+ /* data table styles */
+ .parcoords .row,
+ .parcoords .header {
+ clear: left;
+ font-size: ${theme.typography.sizes.s}px;
+ line-height: 18px;
Review Comment:
@michael-s-molina do you think it makes sense to use grid units for line heights?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #19539: refactor: Removes the CSS files from the Parallel Coordinates plugin
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on code in PR #19539:
URL: https://github.com/apache/superset/pull/19539#discussion_r843810050
##########
superset-frontend/plugins/legacy-plugin-chart-parallel-coordinates/src/ReactParallelCoordinates.jsx:
##########
@@ -34,14 +34,93 @@ ParallelCoordianes.propTypes = {
};
export default styled(ParallelCoordianes)`
- .superset-legacy-chart-parallel-coordinates {
- div.grid {
- overflow: auto;
- div.row {
- &:hover {
- background-color: ${({ theme }) => theme.colors.grayscale.light2};
+ ${({ theme }) => `
+ .superset-legacy-chart-parallel-coordinates {
+ div.grid {
+ overflow: auto;
+ div.row {
+ &:hover {
+ background-color: ${theme.colors.grayscale.light2};
+ }
}
}
}
- }
+ .parcoords svg,
+ .parcoords canvas {
+ font-size: ${theme.typography.sizes.s}px;
+ position: absolute;
+ }
+ .parcoords > canvas {
+ pointer-events: none;
+ }
+
+ .parcoords text.label {
+ font: 100%;
+ font-size: ${theme.typography.sizes.s}px;
+ cursor: drag;
+ }
+ .parcoords rect.background {
+ fill: transparent;
+ }
+ .parcoords rect.background:hover {
+ fill: ${addAlpha(theme.colors.grayscale.base, 0.2)};
+ }
+ .parcoords .resize rect {
+ fill: ${addAlpha(theme.colors.grayscale.dark2, 0.1)};
+ }
+ .parcoords rect.extent {
+ fill: ${addAlpha(theme.colors.grayscale.light5, 0.25)};
+ stroke: ${addAlpha(theme.colors.grayscale.dark2, 0.6)};
+ }
+ .parcoords .axis line,
+ .parcoords .axis path {
+ fill: none;
+ stroke: ${theme.colors.grayscale.dark1};
+ shape-rendering: crispEdges;
+ }
+ .parcoords canvas {
+ opacity: 1;
+ -moz-transition: opacity 0.3s;
+ -webkit-transition: opacity 0.3s;
+ -o-transition: opacity 0.3s;
+ }
+ .parcoords canvas.faded {
+ opacity: ${theme.opacity.mediumLight};
+ }
+ .parcoords {
+ -webkit-touch-callout: none;
+ -webkit-user-select: none;
+ -khtml-user-select: none;
+ -moz-user-select: none;
+ -ms-user-select: none;
+ user-select: none;
+ background-color: ${theme.colors.grayscale.light5};
+ }
+
+ /* data table styles */
+ .parcoords .row,
+ .parcoords .header {
+ clear: left;
+ font-size: ${theme.typography.sizes.s}px;
+ line-height: 18px;
Review Comment:
We'll have a specific category for line-heights in our theme. We just need to figure out which ones should be available and include them with the other theme suggestions for the design team. Let's tackle line-heights in a specific task force.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #19539: refactor: Removes the CSS files from the Parallel Coordinates plugin
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged PR #19539:
URL: https://github.com/apache/superset/pull/19539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org