You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/21 16:24:10 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34059: [SPARK-36670][FOLLOWUP][TEST] Remove brotli-codec dependency
dongjoon-hyun commented on a change in pull request #34059:
URL: https://github.com/apache/spark/pull/34059#discussion_r713211475
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceCodecSuite.scala
##########
@@ -57,12 +57,7 @@ class ParquetCodecSuite extends FileSourceCodecSuite {
override val codecConfigName: String = SQLConf.PARQUET_COMPRESSION.key
// Exclude "lzo" because it is GPL-licenced so not included in Hadoop.
override protected def availableCodecs: Seq[String] =
- if (System.getProperty("os.arch") == "aarch64") {
- // Exclude "brotli" due to PARQUET-1975.
- Seq("none", "uncompressed", "snappy", "lz4", "gzip", "zstd")
- } else {
- Seq("none", "uncompressed", "snappy", "lz4", "gzip", "brotli", "zstd")
- }
Review comment:
BTW, @gengliangwang . Could you add some comment? Otherwise, someone may want to try to re-add it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org