You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/11 15:16:13 UTC
[GitHub] [pulsar] lordcheng10 opened a new pull request, #18006: [improve][broker] Reduce unnecessary persistence of markdelete
lordcheng10 opened a new pull request, #18006:
URL: https://github.com/apache/pulsar/pull/18006
### Motivation
Reduce unnecessary persistence of markdelete:
https://github.com/apache/pulsar/blob/36806853b5a445299d8f9a6ba89905c1915345a3/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java#L1971-L1980
https://github.com/apache/pulsar/blob/36806853b5a445299d8f9a6ba89905c1915345a3/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java#L1982-L1999
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #18006: [improve][broker] Reduce unnecessary persistence of markdelete
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #18006:
URL: https://github.com/apache/pulsar/pull/18006#issuecomment-1275641571
> 1. persistentMarkDeletePosition
I will add test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #18006: [improve][broker] Reduce unnecessary persistence of markdelete
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #18006:
URL: https://github.com/apache/pulsar/pull/18006#issuecomment-1274873189
@lhotari PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #18006: [improve][broker] Reduce unnecessary persistence of markdelete
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #18006:
URL: https://github.com/apache/pulsar/pull/18006#issuecomment-1278441553
Close this PR.
I submitted this change to https://github.com/apache/pulsar/pull/18042 because they are the same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #18006: [improve][broker] Reduce unnecessary persistence of markdelete
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #18006:
URL: https://github.com/apache/pulsar/pull/18006#issuecomment-1275576682
> The change looks good me.
>
> It's better to add a test since this looks like a boundary problem. We should have a test to enforce correct behavior
OK , I will fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 closed pull request #18006: [improve][broker] Reduce unnecessary persistence of markdelete
Posted by GitBox <gi...@apache.org>.
lordcheng10 closed pull request #18006: [improve][broker] Reduce unnecessary persistence of markdelete
URL: https://github.com/apache/pulsar/pull/18006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org