You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/04/30 10:15:29 UTC
Review Request 58876: Need to show data in sorted order in Hive view
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58876/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-20139
https://issues.apache.org/jira/browse/AMBARI-20139
Repository: ambari
Description
-------
Data is shown in the folowing way.
Case 1: Tables list view in 'Query' Tab and 'Tables' tab
Tables should be listed in alphabetical order
Case 2: Jobs should be sorted based on Job Id in 'Jobs' tab. I guess descending order makes sense.
Case 3 : 'Saved Queries' and 'UDFs' tab
Result should be sorted based on user action time. Recent action should come first.
Case 4: 'Settings' tab :
Lexicographical order based on KEY.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js be2771c
contrib/views/hive20/src/main/resources/ui/app/components/setting-list.js 72a83a3
contrib/views/hive20/src/main/resources/ui/app/controllers/udfs.js dc99fd1
contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js e896348
contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 68e06a9
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 766157a
contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs 338828e
contrib/views/hive20/src/main/resources/ui/app/templates/components/setting-list.hbs c3f9c76
contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs ce7315f
contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs f2efaca
Diff: https://reviews.apache.org/r/58876/diff/1/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 58876: Need to show data in sorted order in Hive
view
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58876/
-----------------------------------------------------------
(Updated April 30, 2017, 3:35 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-20139
https://issues.apache.org/jira/browse/AMBARI-20139
Repository: ambari
Description
-------
Data is shown in the folowing way.
Case 1: Tables list view in 'Query' Tab and 'Tables' tab
Tables should be listed in alphabetical order
Case 2: Jobs should be sorted based on Job Id in 'Jobs' tab. I guess descending order makes sense.
Case 3 : 'Saved Queries' and 'UDFs' tab
Result should be sorted based on user action time. Recent action should come first.
Case 4: 'Settings' tab :
Lexicographical order based on KEY.
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js be2771c
contrib/views/hive20/src/main/resources/ui/app/components/setting-list.js 72a83a3
contrib/views/hive20/src/main/resources/ui/app/controllers/savedqueries.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/controllers/udfs.js dc99fd1
contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js e896348
contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 68e06a9
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 766157a
contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs 338828e
contrib/views/hive20/src/main/resources/ui/app/templates/components/setting-list.hbs c3f9c76
contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs ce7315f
contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs f2efaca
Diff: https://reviews.apache.org/r/58876/diff/2/
Changes: https://reviews.apache.org/r/58876/diff/1-2/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 58876: Need to show data in sorted order in Hive
view
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58876/#review173448
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On April 30, 2017, 10:15 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58876/
> -----------------------------------------------------------
>
> (Updated April 30, 2017, 10:15 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20139
> https://issues.apache.org/jira/browse/AMBARI-20139
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Data is shown in the folowing way.
> Case 1: Tables list view in 'Query' Tab and 'Tables' tab
> Tables should be listed in alphabetical order
> Case 2: Jobs should be sorted based on Job Id in 'Jobs' tab. I guess descending order makes sense.
> Case 3 : 'Saved Queries' and 'UDFs' tab
> Result should be sorted based on user action time. Recent action should come first.
> Case 4: 'Settings' tab :
> Lexicographical order based on KEY.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js be2771c
> contrib/views/hive20/src/main/resources/ui/app/components/setting-list.js 72a83a3
> contrib/views/hive20/src/main/resources/ui/app/controllers/udfs.js dc99fd1
> contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js e896348
> contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 68e06a9
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 766157a
> contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs 338828e
> contrib/views/hive20/src/main/resources/ui/app/templates/components/setting-list.hbs c3f9c76
> contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs ce7315f
> contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs f2efaca
>
>
> Diff: https://reviews.apache.org/r/58876/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 58876: Need to show data in sorted order in Hive
view
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58876/#review173445
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On April 30, 2017, 10:15 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58876/
> -----------------------------------------------------------
>
> (Updated April 30, 2017, 10:15 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20139
> https://issues.apache.org/jira/browse/AMBARI-20139
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Data is shown in the folowing way.
> Case 1: Tables list view in 'Query' Tab and 'Tables' tab
> Tables should be listed in alphabetical order
> Case 2: Jobs should be sorted based on Job Id in 'Jobs' tab. I guess descending order makes sense.
> Case 3 : 'Saved Queries' and 'UDFs' tab
> Result should be sorted based on user action time. Recent action should come first.
> Case 4: 'Settings' tab :
> Lexicographical order based on KEY.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js be2771c
> contrib/views/hive20/src/main/resources/ui/app/components/setting-list.js 72a83a3
> contrib/views/hive20/src/main/resources/ui/app/controllers/udfs.js dc99fd1
> contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js e896348
> contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 68e06a9
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 766157a
> contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs 338828e
> contrib/views/hive20/src/main/resources/ui/app/templates/components/setting-list.hbs c3f9c76
> contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs ce7315f
> contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs f2efaca
>
>
> Diff: https://reviews.apache.org/r/58876/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>