You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/06 09:44:21 UTC
[GitHub] [apisix] spacewander opened a new pull request #4189: docs: avoid the misleading comment
spacewander opened a new pull request #4189:
URL: https://github.com/apache/apisix/pull/4189
Also remove helpless yaml lint.
Fix #3962
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4189: docs: avoid the misleading comment
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #4189:
URL: https://github.com/apache/apisix/pull/4189#issuecomment-833441108
If we ignore it, there is almost nothing left that can be checked.
I quite regard about accepting yamllint. Several months have been passed, it has been proved that the linter is helpless but causes misleading and inconvenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4189: docs: avoid the misleading comment
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4189:
URL: https://github.com/apache/apisix/pull/4189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4189: docs: avoid the misleading comment
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #4189:
URL: https://github.com/apache/apisix/pull/4189#issuecomment-833442889
Don't try to sell us linter anymore...
We are not an experimental lab for such "modern" technologies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jbampton commented on pull request #4189: docs: avoid the misleading comment
Posted by GitBox <gi...@apache.org>.
jbampton commented on pull request #4189:
URL: https://github.com/apache/apisix/pull/4189#issuecomment-833445268
You are wrong again since the comments disable rule is only one yamllint rule and there are many to check.
There are about 20 yamllint rules :)
Also most of the worlds top projects use yamllint like Apache Airflow and they know it's not helpless.
https://yamllint.readthedocs.io/en/latest/rules.html
<img width="382" alt="Screen Shot 2021-05-06 at 9 15 08 pm" src="https://user-images.githubusercontent.com/418747/117289867-78da9480-aeb0-11eb-8bca-1971f7d24d21.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org