You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2006/02/04 20:05:56 UTC
svn commit: r374908 - /httpd/httpd/branches/2.2.x/STATUS
Author: wrowe
Date: Sat Feb 4 11:05:53 2006
New Revision: 374908
URL: http://svn.apache.org/viewcvs?rev=374908&view=rev
Log:
Clarify a vote; remove a backport completed.
Modified:
httpd/httpd/branches/2.2.x/STATUS
Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewcvs/httpd/httpd/branches/2.2.x/STATUS?rev=374908&r1=374907&r2=374908&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Sat Feb 4 11:05:53 2006
@@ -150,11 +150,12 @@
* Fix mis-shifted 32 bit scope, masked to 64 bits as a method.
URL: http://svn.apache.org/viewcvs?rev=358040&view=rev
- +1: wrowe, mturk
+ +1: mturk
-0: jorton: should use AP_METHOD_BIT
wrowe asks; is this your desired patch? Please vote;
- if (! (reqs[x].method_mask & (1 << m))) {
+ if (! (reqs[x].method_mask & (AP_METHOD_BIT << m))) {
+ +1: wrowe (for flavor requested by jorton)
* mod_cache: Fix PR38017 (mod_cache not working in reverse proxy setup?)
Trunk version of patch:
@@ -180,11 +181,4 @@
+1: rpluem, niq
NOTE: this also supersedes previous fix to PR#37790
- * Solaris build proposal; don't fail on missing .h files within
- a VPATH build, and don't test trees with -d (simply -f the
- expected files) in case a tree such as srclib/apr is actually
- a symlink rather than a true directory in ./buildconf.
- http://svn.apache.org/viewcvs.cgi?rev=374821&view=rev
- http://people.apache.org/~wrowe/fixbuild-2.2.patch
- +1: wrowe, rpluem, colm
Re: svn commit: r374908 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Joe Orton <jo...@redhat.com>.
On Mon, Feb 06, 2006 at 05:52:50PM -0600, William Rowe wrote:
> Ping jorton,
>
> you -0'ed the proposed patch below, with a suggested improvement. I have
> not seen your comments yet on the adjustment to address your concern, which
> I committed a week or two ago.
Yes, that's the change I meant. If you reference a patch I can apply
without using vi I'll +1 it ;)
>
> What's your current vote? Opinions from anyone else?
>
> Bill
>
> >--- httpd/httpd/branches/2.2.x/STATUS (original)
> >+++ httpd/httpd/branches/2.2.x/STATUS Sat Feb 4 11:05:53 2006
> >@@ -150,11 +150,12 @@
> >
> > * Fix mis-shifted 32 bit scope, masked to 64 bits as a method.
> > URL: http://svn.apache.org/viewcvs?rev=358040&view=rev
> >- +1: wrowe, mturk
> >+ +1: mturk
> > -0: jorton: should use AP_METHOD_BIT
> > wrowe asks; is this your desired patch? Please vote;
> > - if (! (reqs[x].method_mask & (1 << m))) {
> > + if (! (reqs[x].method_mask & (AP_METHOD_BIT << m))) {
> >+ +1: wrowe (for flavor requested by jorton)
Re: svn commit: r374908 - /httpd/httpd/branches/2.2.x/STATUS
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Ping jorton,
you -0'ed the proposed patch below, with a suggested improvement. I have
not seen your comments yet on the adjustment to address your concern, which
I committed a week or two ago.
What's your current vote? Opinions from anyone else?
Bill
> --- httpd/httpd/branches/2.2.x/STATUS (original)
> +++ httpd/httpd/branches/2.2.x/STATUS Sat Feb 4 11:05:53 2006
> @@ -150,11 +150,12 @@
>
> * Fix mis-shifted 32 bit scope, masked to 64 bits as a method.
> URL: http://svn.apache.org/viewcvs?rev=358040&view=rev
> - +1: wrowe, mturk
> + +1: mturk
> -0: jorton: should use AP_METHOD_BIT
> wrowe asks; is this your desired patch? Please vote;
> - if (! (reqs[x].method_mask & (1 << m))) {
> + if (! (reqs[x].method_mask & (AP_METHOD_BIT << m))) {
> + +1: wrowe (for flavor requested by jorton)