You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/12/17 09:41:17 UTC
Review Request 54833: Fixed the metrics display bug in agent.html.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54833/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Joseph Wu, and Vinod Kone.
Bugs: MESOS-6750
https://issues.apache.org/jira/browse/MESOS-6750
Repository: mesos
Description
-------
Fixed the metrics display bug in agent.html.
Diffs
-----
src/webui/master/static/agent.html 3d15d55dddd0c15b8e882c2356cab2e1a0ad6291
src/webui/master/static/js/controllers.js 5dcfbdb5ec36590377255d84569861c824738b04
Diff: https://reviews.apache.org/r/54833/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 54833: Fixed the metrics display bug in agent.html.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54833/#review159652
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Dec. 17, 2016, 1:48 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54833/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2016, 1:48 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-6750
> https://issues.apache.org/jira/browse/MESOS-6750
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed the metrics display bug in agent.html.
>
>
> Diffs
> -----
>
> src/webui/master/static/agent.html 3d15d55dddd0c15b8e882c2356cab2e1a0ad6291
> src/webui/master/static/js/controllers.js 5dcfbdb5ec36590377255d84569861c824738b04
>
> Diff: https://reviews.apache.org/r/54833/diff/
>
>
> Testing
> -------
>
> ```
> Test in OS X with mesos-local and mesos-execute
> Don't flick again after apply the patches.
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 54833: Fixed the metrics display bug in agent.html.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54833/
-----------------------------------------------------------
(Updated Dec. 17, 2016, 9:48 a.m.)
Review request for mesos, Benjamin Mahler, Joseph Wu, and Vinod Kone.
Bugs: MESOS-6750
https://issues.apache.org/jira/browse/MESOS-6750
Repository: mesos
Description
-------
Fixed the metrics display bug in agent.html.
Diffs
-----
src/webui/master/static/agent.html 3d15d55dddd0c15b8e882c2356cab2e1a0ad6291
src/webui/master/static/js/controllers.js 5dcfbdb5ec36590377255d84569861c824738b04
Diff: https://reviews.apache.org/r/54833/diff/
Testing (updated)
-------
```
Test in OS X with mesos-local and mesos-execute
Don't flick again after apply the patches.
```
Thanks,
haosdent huang