You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/09/26 03:19:43 UTC
[GitHub] [rocketmq] ChaosYjh opened a new issue #1486:
CleanUnusedTopicCommand performs wrong
ChaosYjh opened a new issue #1486: CleanUnusedTopicCommand performs wrong
URL: https://github.com/apache/rocketmq/issues/1486
**BUG REPORT**
1. Please describe the issue you observed:
- What did you do (The steps to reproduce)?
I found an error in org.apache.rocketmq.tools.command.broker.CleanUnusedTopicCommand when I was using cleanUnusedTopic command.
<img width="839" alt="image" src="https://user-images.githubusercontent.com/27771595/65654193-9267f900-e04a-11e9-897f-66f7d49a5fda.png">
The parameter I used was '-c(clusterName)',but an error happened named "connect to {clusterName}".
I found the command calls incorrect method in source code CleanUnusedTopicCommand#execute line 69.It should call defaultMQAdminExt.cleanUnusedTopic(String cluster) I think.
<img width="613" alt="image" src="https://user-images.githubusercontent.com/27771595/65654751-6ea5b280-e04c-11e9-89f8-0d70a76efd97.png">
And In DefaultMQAdminExt#cleanUnusedTopic,there is a bad call too.It should call defaultMQAdminExtImpl#cleanUnusedTopic(String cluster) as well
<img width="819" alt="image" src="https://user-images.githubusercontent.com/27771595/65654896-db20b180-e04c-11e9-8ab6-3e26031f9f38.png">
2. Please tell us about your environment:
rocketmq4.5.1-release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services