[GitHub] [beam] tvalentyn commented on pull request #26082: Unpin tox version in BeamModulePlugin

["tvalentyn (via GitHub)" <gi...@apache.org>]

tvalentyn commented on PR #26082:
URL: https://github.com/apache/beam/pull/26082#issuecomment-1505826636

   > @tvalentyn any chance you have context on why that's been done?
   
   I don't remember, I think tox version shouldn't be configured in ad-hoc places like that, and I would support controlled upgrades to next major version.
   
   Other places:
   ```
   :beam$ rg " tox==" .
   ./buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
   2760:                "pip install --retries 10 --upgrade tox==3.20.1 -r ${project.rootDir}/sdks/python/build-requirements.txt"
   
   ./sdks/python/apache_beam/io/hdfs_integration_test/Dockerfile
   33:RUN pip install --no-cache-dir tox==3.11.1 -r sdks/python/build-requirements.txt
   
   ./sdks/python/apache_beam/io/azure/integration_test/Dockerfile
   35:RUN pip install --no-cache-dir tox==3.11.1 -r sdks/python/build-requirements.txt
   :beam$ 
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org