You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2018/03/02 02:56:30 UTC

[GitHub] flink pull request #5600: [FLINK-8811] [flip6] Add initial implementation of...

Github user zhangminglei commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5600#discussion_r171754724
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java ---
    @@ -178,6 +181,13 @@ public URI getRestAddress() {
     		}
     	}
     
    +	public HighAvailabilityServices getHighAvailabilityServices() {
    +		synchronized (lock) {
    +			checkState(running, "MiniCluster is not yet running.");
    --- End diff --
    
    I am curious about the lock in this place. Is not such a scene as follow ?
    
    Some tests or ITCase running in maven test simultaneously. And might be change this object at the same time. So, that is why we should have a lock here ?


---