You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Itai Shaked (JIRA)" <ji...@apache.org> on 2018/12/18 18:20:00 UTC

[jira] [Created] (PDFBOX-4411) Support caching of ICC based color spaces

Itai Shaked created PDFBOX-4411:
-----------------------------------

             Summary: Support caching of ICC based color spaces
                 Key: PDFBOX-4411
                 URL: https://issues.apache.org/jira/browse/PDFBOX-4411
             Project: PDFBox
          Issue Type: Improvement
          Components: Rendering
    Affects Versions: 2.0.13
            Reporter: Itai Shaked
         Attachments: Cache_PDICCBased_color_spaces.patch

Following up on PDFBOX-4392 I have noticed ICC color spaces aren't being cached in the resource cache, since they are represented not by a `COSObject` but rather by a `COSArray` with `COSName` of `ICCBased` as the first element and a `COSObject` (the actual profile) as the second element.  

This patch introduces a static `create` method to `PDICCBased` which optionally caches/retrieves the color space from cache. Accordingly, the constructor taking a `COSArray` has been made private, and the validity tests moved to the static `create` method.   

Testing on the example from PDFBOX-4392 the patch improves both time and memory consumption. Presumably it will help with any PDF with ICC-based profiles which are re-used by many images. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org