[GitHub] [shiro] cstamas commented on pull request #308: [SHIRO-816] Hazelcast support does not support HZ v4

[GitBox <gi...@apache.org>]

cstamas commented on pull request #308:
URL: https://github.com/apache/shiro/pull/308#issuecomment-873384953


   @bmarwell 
   
   > And yes, as we are having a maintenance release here, I'd suggest:
   > Add hz4 support in main and 1.8 branch
   > Remove hz3 support from main branch
   > Check that hz3 support works well in the 1.8 branch.
   
   IMO:
   *  "maintenance release" should not up major version of a dependency, source code is good as is (this especially if major version of dependency introduces intentional API breakage)
   * "add hz4 support" is really just "up the dependency and compile" as then byte code will then work with hz4 (but not with hz3)
   * "remove hz3 support from main branch" see above, byte code of this source as-is compiled with hz4 will NOT work with hz3 (just as today compiled against hz3 does NOT work with hz4)
   * "check that hz3 support works well in 1.8 branch" it does, I hope tests are in place
   
   Again, IMO here is nothing to be done, but:
   * drop this PR
   * set HZ version on main branch to hz 4.x
   * (maybe) up the HZ version on 1.8 branch to latest hz 3.x
   * (maybe) clarify that Shiro 1.x works with hz3 and upcoming Shiro 2.x works with hz4
   
   Personally, I'd not complicate things, by adding burden of "magic" to make something work that was never specd/promised to work. HZ4 did intentional Java package changes, similar to javax.servlet vs jakarta.servlet... so next will be to support those as well?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org