Re: ExternalSampleSorter#sortSamplesParallel

[Philippe Mouawad <ph...@gmail.com>]

Hi Graham,
Resurecting this question from Felix as you're working on this.

Regards

On Wed, Dec 30, 2015 at 7:42 PM, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

> Hi all,
>
> in the sortSamplesParallel method two new jobs are created and put into
> workQueue, but are only needed, when parallelize is true. In the
> corresponding method sortFilesParallel the addition of the jobs to the
> workQueue is done only when parallelize is true.
>
> I think it would be correct to change sortSamplesParallel to add the jobs
> to the workQueue in parallel mode only.
>
> What do you think?
>
> Regards,
>  Felix
>



-- 
Cordialement.
Philippe Mouawad.

Re: ExternalSampleSorter#sortSamplesParallel

[Graham Russell <gr...@ham1.co.uk>]

I agree with Felix, however I cannot see where the code is being used.
If someone could explain where and how it's being used then I'm happy to
help test it, otherwise this is more code to delete.

On Tue, 28 Nov 2017 at 21:30 Philippe Mouawad <ph...@gmail.com>
wrote:

> Hi Graham,
> Resurecting this question from Felix as you're working on this.
>
> Regards
>
> On Wed, Dec 30, 2015 at 7:42 PM, Felix Schumacher <
> felix.schumacher@internetallee.de> wrote:
>
> > Hi all,
> >
> > in the sortSamplesParallel method two new jobs are created and put into
> > workQueue, but are only needed, when parallelize is true. In the
> > corresponding method sortFilesParallel the addition of the jobs to the
> > workQueue is done only when parallelize is true.
> >
> > I think it would be correct to change sortSamplesParallel to add the jobs
> > to the workQueue in parallel mode only.
> >
> > What do you think?
> >
> > Regards,
> >  Felix
> >
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>