You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Phillip Cloud (JIRA)" <ji...@apache.org> on 2018/03/29 20:43:00 UTC
[jira] [Commented] (ARROW-2368) DecimalVector#setBigEndian is not
padding correctly for negative values
[ https://issues.apache.org/jira/browse/ARROW-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419734#comment-16419734 ]
Phillip Cloud commented on ARROW-2368:
--------------------------------------
This seems like a fairly straightforward fix. Care to submit a PR?
> DecimalVector#setBigEndian is not padding correctly for negative values
> -----------------------------------------------------------------------
>
> Key: ARROW-2368
> URL: https://issues.apache.org/jira/browse/ARROW-2368
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java - Vectors
> Reporter: Venki Korukanti
> Assignee: Venki Korukanti
> Priority: Blocker
>
> If the input given is less than 16 bytes, we pad zero for the remaining bytes [1]. This is not correct if the value is a negative number. We should pad 0x00 or 0xFF depending upon the number is a positive or negative number. Later when the value is retrieved we end up with an incorrect value.
>
> [1] https://github.com/apache/arrow/blob/master/java/vector/src/main/java/org/apache/arrow/vector/DecimalVector.java#L231
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)