[jira] [Commented] (SOLR-11758) Missing boolVal implementation in FloatDocValues

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-11758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314882#comment-16314882 ] 

ASF subversion and git services commented on SOLR-11758:
--------------------------------------------------------

Commit d03cb44de73bb29e16a3ab927ee57d6eb916789a in lucene-solr's branch refs/heads/master from Chris Hostetter
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d03cb44 ]

SOLR-11758: Fixed FloatDocValues.boolVal to correctly return true for all values != 0.0F


> Missing boolVal implementation in FloatDocValues
> ------------------------------------------------
>
>                 Key: SOLR-11758
>                 URL: https://issues.apache.org/jira/browse/SOLR-11758
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Munendra S N
>            Assignee: Hoss Man
>            Priority: Minor
>         Attachments: SOLR-11758.patch, SOLR-11758.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> In case of *DoubleDocValues*, *boolVal(int doc)* has been implemented but this is missing in case *FloatDocValues*.
> *Impact*: For any DocValues which extends *FloatDocValues* and doesn't implement *boolVal(int doc)*, parent *boolVal* in FucntionValues would be called.
> boolVal implementation in FunctionValues
> {code:java}
>   @Override
>   public boolean boolVal(int doc) throws IOException {
>     return intVal(doc) != 0;
>   }
> {code}
> Let me know if I can work on it



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org