You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2018/04/03 17:50:31 UTC

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces
......................................................................


Patch Set 6: Code-Review+1

This looks OK to me. I'd like someone whose more of a bash expert to give this a final +2.


-- 
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 6
Gerrit-Owner: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Apr 2018 17:50:31 +0000
Gerrit-HasComments: No