You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@vxquery.apache.org by "Preston Carman (JIRA)" <ji...@apache.org> on 2012/06/21 22:04:42 UTC
[jira] [Created] (VXQUERY-35) Functions based on substring matching
Preston Carman created VXQUERY-35:
-------------------------------------
Summary: Functions based on substring matching
Key: VXQUERY-35
URL: https://issues.apache.org/jira/browse/VXQUERY-35
Project: VXQuery
Issue Type: Bug
Reporter: Preston Carman
The next set of functions suggested are functions dealing with substring matching. The details and list can be found at http://www.w3.org/TR/xquery-operators/#substring.functions.
fn:contains - Indicates whether one xs:string contains another xs:string. A collation may be specified.
fn:starts-with - Indicates whether the value of one xs:string begins with the collation units of another xs:string. A collation may be specified.
fn:ends-with - Indicates whether the value of one xs:string ends with the collation units of another xs:string. A collation may be specified.
fn:substring-before - Returns the collation units of one xs:string that precede in that xs:string the collation units of another xs:string. A collation may be specified.
fn:substring-after - Returns the collation units of xs:string that follow in that xs:string the collation units of another xs:string. A collation may be specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VXQUERY-35) Functions based on substring
matching
Posted by "Till Westmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VXQUERY-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408887#comment-13408887 ]
Till Westmann commented on VXQUERY-35:
--------------------------------------
committed patch for fn:substring-before and fn:substring-after.
> Functions based on substring matching
> -------------------------------------
>
> Key: VXQUERY-35
> URL: https://issues.apache.org/jira/browse/VXQUERY-35
> Project: VXQuery
> Issue Type: Sub-task
> Reporter: Preston Carman
> Assignee: Till Westmann
> Labels: patch
> Attachments: StringMatchingFunctions1.patch, StringMatchingFunctions2.patch, StringMatchingFunctions3.patch, StringMatchingFunctions4.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> The next set of functions suggested are functions dealing with substring matching. The details and list can be found at http://www.w3.org/TR/xquery-operators/#substring.functions.
> fn:contains - Indicates whether one xs:string contains another xs:string. A collation may be specified.
> fn:starts-with - Indicates whether the value of one xs:string begins with the collation units of another xs:string. A collation may be specified.
> fn:ends-with - Indicates whether the value of one xs:string ends with the collation units of another xs:string. A collation may be specified.
> fn:substring-before - Returns the collation units of one xs:string that precede in that xs:string the collation units of another xs:string. A collation may be specified.
> fn:substring-after - Returns the collation units of xs:string that follow in that xs:string the collation units of another xs:string. A collation may be specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VXQUERY-35) Functions based on substring
matching
Posted by "Till Westmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VXQUERY-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408892#comment-13408892 ]
Till Westmann commented on VXQUERY-35:
--------------------------------------
committed patches for fn:contains and fn:ends-with
> Functions based on substring matching
> -------------------------------------
>
> Key: VXQUERY-35
> URL: https://issues.apache.org/jira/browse/VXQUERY-35
> Project: VXQuery
> Issue Type: Sub-task
> Reporter: Preston Carman
> Assignee: Till Westmann
> Labels: patch
> Attachments: StringMatchingFunctions1.patch, StringMatchingFunctions2.patch, StringMatchingFunctions3.patch, StringMatchingFunctions4.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> The next set of functions suggested are functions dealing with substring matching. The details and list can be found at http://www.w3.org/TR/xquery-operators/#substring.functions.
> fn:contains - Indicates whether one xs:string contains another xs:string. A collation may be specified.
> fn:starts-with - Indicates whether the value of one xs:string begins with the collation units of another xs:string. A collation may be specified.
> fn:ends-with - Indicates whether the value of one xs:string ends with the collation units of another xs:string. A collation may be specified.
> fn:substring-before - Returns the collation units of one xs:string that precede in that xs:string the collation units of another xs:string. A collation may be specified.
> fn:substring-after - Returns the collation units of xs:string that follow in that xs:string the collation units of another xs:string. A collation may be specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VXQUERY-35) Functions based on substring matching
Posted by "Preston Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VXQUERY-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Preston Carman updated VXQUERY-35:
----------------------------------
Issue Type: Sub-task (was: Bug)
Parent: VXQUERY-31
> Functions based on substring matching
> -------------------------------------
>
> Key: VXQUERY-35
> URL: https://issues.apache.org/jira/browse/VXQUERY-35
> Project: VXQuery
> Issue Type: Sub-task
> Reporter: Preston Carman
> Labels: patch
> Attachments: StringMatchingFunctions1.patch, StringMatchingFunctions2.patch, StringMatchingFunctions3.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> The next set of functions suggested are functions dealing with substring matching. The details and list can be found at http://www.w3.org/TR/xquery-operators/#substring.functions.
> fn:contains - Indicates whether one xs:string contains another xs:string. A collation may be specified.
> fn:starts-with - Indicates whether the value of one xs:string begins with the collation units of another xs:string. A collation may be specified.
> fn:ends-with - Indicates whether the value of one xs:string ends with the collation units of another xs:string. A collation may be specified.
> fn:substring-before - Returns the collation units of one xs:string that precede in that xs:string the collation units of another xs:string. A collation may be specified.
> fn:substring-after - Returns the collation units of xs:string that follow in that xs:string the collation units of another xs:string. A collation may be specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VXQUERY-35) Functions based on substring matching
Posted by "Preston Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VXQUERY-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Preston Carman updated VXQUERY-35:
----------------------------------
Attachment: StringMatchingFunctions4.patch
Updated the substring before and after functions using a more iterator approach. Ready for your review.
> Functions based on substring matching
> -------------------------------------
>
> Key: VXQUERY-35
> URL: https://issues.apache.org/jira/browse/VXQUERY-35
> Project: VXQuery
> Issue Type: Sub-task
> Reporter: Preston Carman
> Labels: patch
> Attachments: StringMatchingFunctions1.patch, StringMatchingFunctions2.patch, StringMatchingFunctions3.patch, StringMatchingFunctions4.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> The next set of functions suggested are functions dealing with substring matching. The details and list can be found at http://www.w3.org/TR/xquery-operators/#substring.functions.
> fn:contains - Indicates whether one xs:string contains another xs:string. A collation may be specified.
> fn:starts-with - Indicates whether the value of one xs:string begins with the collation units of another xs:string. A collation may be specified.
> fn:ends-with - Indicates whether the value of one xs:string ends with the collation units of another xs:string. A collation may be specified.
> fn:substring-before - Returns the collation units of one xs:string that precede in that xs:string the collation units of another xs:string. A collation may be specified.
> fn:substring-after - Returns the collation units of xs:string that follow in that xs:string the collation units of another xs:string. A collation may be specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (VXQUERY-35) Functions based on substring
matching
Posted by "Till Westmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VXQUERY-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Till Westmann reassigned VXQUERY-35:
------------------------------------
Assignee: Till Westmann
> Functions based on substring matching
> -------------------------------------
>
> Key: VXQUERY-35
> URL: https://issues.apache.org/jira/browse/VXQUERY-35
> Project: VXQuery
> Issue Type: Sub-task
> Reporter: Preston Carman
> Assignee: Till Westmann
> Labels: patch
> Attachments: StringMatchingFunctions1.patch, StringMatchingFunctions2.patch, StringMatchingFunctions3.patch, StringMatchingFunctions4.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> The next set of functions suggested are functions dealing with substring matching. The details and list can be found at http://www.w3.org/TR/xquery-operators/#substring.functions.
> fn:contains - Indicates whether one xs:string contains another xs:string. A collation may be specified.
> fn:starts-with - Indicates whether the value of one xs:string begins with the collation units of another xs:string. A collation may be specified.
> fn:ends-with - Indicates whether the value of one xs:string ends with the collation units of another xs:string. A collation may be specified.
> fn:substring-before - Returns the collation units of one xs:string that precede in that xs:string the collation units of another xs:string. A collation may be specified.
> fn:substring-after - Returns the collation units of xs:string that follow in that xs:string the collation units of another xs:string. A collation may be specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VXQUERY-35) Functions based on substring matching
Posted by "Preston Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VXQUERY-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Preston Carman updated VXQUERY-35:
----------------------------------
Attachment: StringMatchingFunctions3.patch
Realized I could use the iterators in other places. Now all functions that iterator over individual characters use the iterator objects. Seems like contains, substring-before and substring-after have some potential for code reuse.
> Functions based on substring matching
> -------------------------------------
>
> Key: VXQUERY-35
> URL: https://issues.apache.org/jira/browse/VXQUERY-35
> Project: VXQuery
> Issue Type: Bug
> Reporter: Preston Carman
> Labels: patch
> Attachments: StringMatchingFunctions1.patch, StringMatchingFunctions2.patch, StringMatchingFunctions3.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> The next set of functions suggested are functions dealing with substring matching. The details and list can be found at http://www.w3.org/TR/xquery-operators/#substring.functions.
> fn:contains - Indicates whether one xs:string contains another xs:string. A collation may be specified.
> fn:starts-with - Indicates whether the value of one xs:string begins with the collation units of another xs:string. A collation may be specified.
> fn:ends-with - Indicates whether the value of one xs:string ends with the collation units of another xs:string. A collation may be specified.
> fn:substring-before - Returns the collation units of one xs:string that precede in that xs:string the collation units of another xs:string. A collation may be specified.
> fn:substring-after - Returns the collation units of xs:string that follow in that xs:string the collation units of another xs:string. A collation may be specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VXQUERY-35) Functions based on substring
matching
Posted by "Till Westmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VXQUERY-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Till Westmann resolved VXQUERY-35.
----------------------------------
Resolution: Fixed
> Functions based on substring matching
> -------------------------------------
>
> Key: VXQUERY-35
> URL: https://issues.apache.org/jira/browse/VXQUERY-35
> Project: VXQuery
> Issue Type: Sub-task
> Reporter: Preston Carman
> Assignee: Till Westmann
> Labels: patch
> Attachments: StringMatchingFunctions1.patch, StringMatchingFunctions2.patch, StringMatchingFunctions3.patch, StringMatchingFunctions4.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> The next set of functions suggested are functions dealing with substring matching. The details and list can be found at http://www.w3.org/TR/xquery-operators/#substring.functions.
> fn:contains - Indicates whether one xs:string contains another xs:string. A collation may be specified.
> fn:starts-with - Indicates whether the value of one xs:string begins with the collation units of another xs:string. A collation may be specified.
> fn:ends-with - Indicates whether the value of one xs:string ends with the collation units of another xs:string. A collation may be specified.
> fn:substring-before - Returns the collation units of one xs:string that precede in that xs:string the collation units of another xs:string. A collation may be specified.
> fn:substring-after - Returns the collation units of xs:string that follow in that xs:string the collation units of another xs:string. A collation may be specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VXQUERY-35) Functions based on substring
matching
Posted by "Till Westmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VXQUERY-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402922#comment-13402922 ]
Till Westmann commented on VXQUERY-35:
--------------------------------------
I've reviewed the 3rd patch and committed most (but not all) of the functions. I think that fn:substring-before and fn:substring-after can be written more compactly and for fn:contains I could not convince myself yet, that it works correctly in all cases. However, I didn't manage to come up with concrete proposals for improvement so far.
> Functions based on substring matching
> -------------------------------------
>
> Key: VXQUERY-35
> URL: https://issues.apache.org/jira/browse/VXQUERY-35
> Project: VXQuery
> Issue Type: Bug
> Reporter: Preston Carman
> Labels: patch
> Attachments: StringMatchingFunctions1.patch, StringMatchingFunctions2.patch, StringMatchingFunctions3.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> The next set of functions suggested are functions dealing with substring matching. The details and list can be found at http://www.w3.org/TR/xquery-operators/#substring.functions.
> fn:contains - Indicates whether one xs:string contains another xs:string. A collation may be specified.
> fn:starts-with - Indicates whether the value of one xs:string begins with the collation units of another xs:string. A collation may be specified.
> fn:ends-with - Indicates whether the value of one xs:string ends with the collation units of another xs:string. A collation may be specified.
> fn:substring-before - Returns the collation units of one xs:string that precede in that xs:string the collation units of another xs:string. A collation may be specified.
> fn:substring-after - Returns the collation units of xs:string that follow in that xs:string the collation units of another xs:string. A collation may be specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VXQUERY-35) Functions based on substring matching
Posted by "Preston Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VXQUERY-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Preston Carman updated VXQUERY-35:
----------------------------------
Attachment: StringMatchingFunctions2.patch
Found some functions I missed with the iterator. This update contains compare and codepoint-equal functions for comparison (VXQUERY-41).
The only functions that do not fully utilize the iterator are contains, substring-before and substring-after.
Feedback welcome.
> Functions based on substring matching
> -------------------------------------
>
> Key: VXQUERY-35
> URL: https://issues.apache.org/jira/browse/VXQUERY-35
> Project: VXQuery
> Issue Type: Bug
> Reporter: Preston Carman
> Labels: patch
> Attachments: StringMatchingFunctions1.patch, StringMatchingFunctions2.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> The next set of functions suggested are functions dealing with substring matching. The details and list can be found at http://www.w3.org/TR/xquery-operators/#substring.functions.
> fn:contains - Indicates whether one xs:string contains another xs:string. A collation may be specified.
> fn:starts-with - Indicates whether the value of one xs:string begins with the collation units of another xs:string. A collation may be specified.
> fn:ends-with - Indicates whether the value of one xs:string ends with the collation units of another xs:string. A collation may be specified.
> fn:substring-before - Returns the collation units of one xs:string that precede in that xs:string the collation units of another xs:string. A collation may be specified.
> fn:substring-after - Returns the collation units of xs:string that follow in that xs:string the collation units of another xs:string. A collation may be specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VXQUERY-35) Functions based on substring matching
Posted by "Preston Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VXQUERY-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Preston Carman updated VXQUERY-35:
----------------------------------
Attachment: StringMatchingFunctions1.patch
The patch contains a new string iterator along with the new functions defined in the ticket.
Collation is being ignored at this time.
> Functions based on substring matching
> -------------------------------------
>
> Key: VXQUERY-35
> URL: https://issues.apache.org/jira/browse/VXQUERY-35
> Project: VXQuery
> Issue Type: Bug
> Reporter: Preston Carman
> Labels: patch
> Attachments: StringMatchingFunctions1.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> The next set of functions suggested are functions dealing with substring matching. The details and list can be found at http://www.w3.org/TR/xquery-operators/#substring.functions.
> fn:contains - Indicates whether one xs:string contains another xs:string. A collation may be specified.
> fn:starts-with - Indicates whether the value of one xs:string begins with the collation units of another xs:string. A collation may be specified.
> fn:ends-with - Indicates whether the value of one xs:string ends with the collation units of another xs:string. A collation may be specified.
> fn:substring-before - Returns the collation units of one xs:string that precede in that xs:string the collation units of another xs:string. A collation may be specified.
> fn:substring-after - Returns the collation units of xs:string that follow in that xs:string the collation units of another xs:string. A collation may be specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira