[GitHub] [pinot] etolbakov commented on a diff in pull request #9884: WIP - feat: add compressed file support for ORCRecordReader

[GitBox <gi...@apache.org>]

etolbakov commented on code in PR #9884:
URL: https://github.com/apache/pinot/pull/9884#discussion_r1041458216


##########
pinot-plugins/pinot-input-format/pinot-orc/src/main/java/org/apache/pinot/plugin/inputformat/orc/ORCRecordReader.java:
##########
@@ -106,6 +111,18 @@ public void init(File dataFile, @Nullable Set<String> fieldsToRead, @Nullable Re
     _nextRowId = 0;
   }
 
+  private File unpackIfRequired(File dataFile) throws IOException {

Review Comment:
   done!
   I decided to add `extension` as a function parameter explicitly, as you've mentioned above the archive will not necessarily have `.gz` suffix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org