You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2016/04/12 04:06:40 UTC
spark git commit: [SPARK-14520][SQL] Use correct return type in
VectorizedParquetInputFormat
Repository: spark
Updated Branches:
refs/heads/master 6f27027d9 -> 26d7af911
[SPARK-14520][SQL] Use correct return type in VectorizedParquetInputFormat
## What changes were proposed in this pull request?
JIRA: https://issues.apache.org/jira/browse/SPARK-14520
`VectorizedParquetInputFormat` inherits `ParquetInputFormat` and overrides `createRecordReader`. However, its overridden `createRecordReader` returns a `ParquetRecordReader`. It should return a `RecordReader`. Otherwise, `ClassCastException` will be thrown.
## How was this patch tested?
Existing tests.
Author: Liang-Chi Hsieh <si...@tw.ibm.com>
Closes #12292 from viirya/fix-vectorized-input-format.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/26d7af91
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/26d7af91
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/26d7af91
Branch: refs/heads/master
Commit: 26d7af9119a73d851c86314b4a207c0bfe437082
Parents: 6f27027
Author: Liang-Chi Hsieh <si...@tw.ibm.com>
Authored: Mon Apr 11 19:06:38 2016 -0700
Committer: Reynold Xin <rx...@databricks.com>
Committed: Mon Apr 11 19:06:38 2016 -0700
----------------------------------------------------------------------
.../sql/execution/datasources/parquet/ParquetRelation.scala | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/26d7af91/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala
index ca6803b..bcb2b2d 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala
@@ -476,8 +476,8 @@ private[sql] class DefaultSource
final class VectorizedParquetInputFormat extends ParquetInputFormat[InternalRow] {
override def createRecordReader(
inputSplit: InputSplit,
- taskAttemptContext: TaskAttemptContext): ParquetRecordReader[InternalRow] = {
- new VectorizedParquetRecordReader().asInstanceOf[ParquetRecordReader[InternalRow]]
+ taskAttemptContext: TaskAttemptContext): RecordReader[Void, InternalRow] = {
+ new VectorizedParquetRecordReader().asInstanceOf[RecordReader[Void, InternalRow]]
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org