You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/10 01:00:43 UTC
[GitHub] [incubator-mxnet] rongzha1 opened a new pull request #18009:
[mkldnn]Mkldnn bn opt backport from master to 1.7x
rongzha1 opened a new pull request #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009
## Description ##
[mkldnn]Mkldnn bn opt backport from master to 1.7x
@TaoLv @pengzhao-intel @ciyongch
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] rongzha1 closed pull request #18009:
[mkldnn]Mkldnn bn opt backport from master to 1.7x
Posted by GitBox <gi...@apache.org>.
rongzha1 closed pull request #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ciyongch commented on issue #18009:
[mkldnn]Mkldnn bn opt backport from master to 1.7x
Posted by GitBox <gi...@apache.org>.
ciyongch commented on issue #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009#issuecomment-611845220
Adding this to 1.7.0 roadmap https://github.com/apache/incubator-mxnet/issues/16864
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18009:
[mkldnn]Mkldnn bn opt backport from master to 1.7x
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009#issuecomment-613761957
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] rongzha1 opened a new pull request #18009:
[mkldnn]Mkldnn bn opt backport from master to 1.7x
Posted by GitBox <gi...@apache.org>.
rongzha1 opened a new pull request #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009
## Description ##
[mkldnn]Mkldnn bn opt backport from master to 1.7x
@TaoLv @pengzhao-intel @ciyongch
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18009:
[mkldnn]Mkldnn bn opt backport from master to 1.7x
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009#issuecomment-611823743
Hey @rongzha1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-gpu, centos-gpu, unix-cpu, unix-gpu, windows-cpu, clang, website, edge, miscellaneous, sanity, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] rongzha1 commented on issue #18009:
[mkldnn]Mkldnn bn opt backport from master to 1.7x
Posted by GitBox <gi...@apache.org>.
rongzha1 commented on issue #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009#issuecomment-611832285
@mxnet-bot run ci [all]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] rongzha1 commented on issue #18009:
[mkldnn]Mkldnn bn opt backport from master to 1.7x
Posted by GitBox <gi...@apache.org>.
rongzha1 commented on issue #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009#issuecomment-613761935
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] rongzha1 commented on issue #18009:
[mkldnn]Mkldnn bn opt backport from master to 1.7x
Posted by GitBox <gi...@apache.org>.
rongzha1 commented on issue #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009#issuecomment-612713136
@mxnet-bot run ci [all]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18009:
[mkldnn]Mkldnn bn opt backport from master to 1.7x
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009#issuecomment-613761794
Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ciyongch commented on issue #18009:
[mkldnn]Mkldnn bn opt backport from master to 1.7x
Posted by GitBox <gi...@apache.org>.
ciyongch commented on issue #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009#issuecomment-611824294
Assume you're going to backport this PR to v1.x branch, but currently you choose master branch. Please double check the target branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18009:
[mkldnn]Mkldnn bn opt backport from master to 1.7x
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009#issuecomment-612713191
Jenkins CI successfully triggered : [clang, edge, unix-gpu, unix-cpu, centos-cpu, windows-cpu, centos-gpu, windows-gpu, website, miscellaneous, sanity]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] rongzha1 commented on issue #18009:
[mkldnn]Mkldnn bn opt backport from master to 1.7x
Posted by GitBox <gi...@apache.org>.
rongzha1 commented on issue #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009#issuecomment-613761791
@mxnet-bot run ci unix-gpu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #18009: [mkldnn]Mkldnn
bn opt backport from master to 1.7x
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009#issuecomment-611828778
I edited the target branch accordingly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] rongzha1 commented on issue #18009:
[mkldnn]Mkldnn bn opt backport from master to 1.7x
Posted by GitBox <gi...@apache.org>.
rongzha1 commented on issue #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009#issuecomment-611830672
> I edited the target branch accordingly
thank you very much.
I have just re-pr it to 1.7.x a minites ago
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] pengzhao-intel merged pull request #18009:
[mkldnn]Mkldnn bn opt backport from master to 1.7x
Posted by GitBox <gi...@apache.org>.
pengzhao-intel merged pull request #18009: [mkldnn]Mkldnn bn opt backport from master to 1.7x
URL: https://github.com/apache/incubator-mxnet/pull/18009
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services