You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2015/04/24 08:20:38 UTC
[jira] [Commented] (SLING-4655) Servlet Resolver does not use
registered servlet's service.ranking property
[ https://issues.apache.org/jira/browse/SLING-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510524#comment-14510524 ]
Felix Meschberger commented on SLING-4655:
------------------------------------------
Simple patch:
{noformat}
Index: src/main/java/org/apache/sling/servlets/resolver/internal/SlingServletResolver.java
===================================================================
--- src/main/java/org/apache/sling/servlets/resolver/internal/SlingServletResolver.java (Revision 1675785)
+++ src/main/java/org/apache/sling/servlets/resolver/internal/SlingServletResolver.java (Arbeitskopie)
@@ -1000,6 +1000,12 @@
params.put(Constants.SERVICE_DESCRIPTION, "ServletResourceProvider for Servlets at "
+ Arrays.asList(provider.getServletPaths()));
+ // inherit service ranking
+ Object rank = reference.getProperty(Constants.SERVICE_RANKING);
+ if (rank instanceof Integer) {
+ params.put(Constants.SERVICE_RANKING, rank);
+ }
+
final ServiceRegistration reg = context.getBundleContext()
.registerService(ResourceProvider.SERVICE_NAME, provider, params);
{noformat}
> Servlet Resolver does not use registered servlet's service.ranking property
> ---------------------------------------------------------------------------
>
> Key: SLING-4655
> URL: https://issues.apache.org/jira/browse/SLING-4655
> Project: Sling
> Issue Type: Bug
> Components: Servlets
> Affects Versions: Servlets Resolver 2.3.6
> Reporter: Felix Meschberger
>
> The Servlet Resolver registers a ResourceProvider for each Servlet service registered and handled by the ServletResolver, that is, those with a Sling servlet registration property.
> As the ResourceResolver supports ranking of ResourceProviders with the same root path, the ServletResolver should really register ResourceProvider services for servlets including the servlet service's service ranking property, if available.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)