You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Marvin Froeder (JIRA)" <ji...@codehaus.org> on 2008/10/28 18:24:51 UTC

[jira] Created: (MNG-3807) Maven is not interpolatin Properties at plugin configuration

Maven is not interpolatin Properties at plugin configuration
------------------------------------------------------------

                 Key: MNG-3807
                 URL: http://jira.codehaus.org/browse/MNG-3807
             Project: Maven 2
          Issue Type: Bug
          Components: Inheritance and Interpolation
            Reporter: Marvin Froeder


My plugin has a configuration like this:
    /**
     * My Properties.
     *
     * @parameter
     */
    private Properties myProperties;


When I configure like this:
<myProperties>
  <property>
    <name>propertyName1</name>
    <value>${buildnumber}</value> <!-- property injected on maven properties by  http://mojo.codehaus.org/buildnumber-maven-plugin/ -->
  <property>
</myProperties>

Maven doesn't interpolate the buildnumber.  But the value is available at project.getProperties().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-3807) Maven is not interpolatin Properties at plugin configuration

Posted by "Marvin Froeder (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marvin Froeder updated MNG-3807:
--------------------------------

    Affects Version/s: 2.0.9
                       2.1.0-M1

> Maven is not interpolatin Properties at plugin configuration
> ------------------------------------------------------------
>
>                 Key: MNG-3807
>                 URL: http://jira.codehaus.org/browse/MNG-3807
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Inheritance and Interpolation
>    Affects Versions: 2.0.9, 2.1.0-M1
>            Reporter: Marvin Froeder
>
> My plugin has a configuration like this:
> {noformat} 
>     /**
>      * My Properties.
>      *
>      * @parameter
>      */
>     private Properties myProperties;
> {noformat} 
> When I configure like this:
> {noformat} 
> <myProperties>
>   <property>
>     <name>propertyName1</name>
>     <value>${buildnumber}</value> <!-- property injected on maven properties by  http://mojo.codehaus.org/buildnumber-maven-plugin/ -->
>   <property>
> </myProperties>
> {noformat} 
> Maven doesn't interpolate the buildnumber.  But the value is available at project.getProperties().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-3807) Maven is not interpolatin Properties at plugin configuration

Posted by "Marvin Froeder (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marvin Froeder updated MNG-3807:
--------------------------------

    Description: 
My plugin has a configuration like this:
{noformat} 
    /**
     * My Properties.
     *
     * @parameter
     */
    private Properties myProperties;
{noformat} 

When I configure like this:
{noformat} 
<myProperties>
  <property>
    <name>propertyName1</name>
    <value>${buildnumber}</value> <!-- property injected on maven properties by  http://mojo.codehaus.org/buildnumber-maven-plugin/ -->
  <property>
</myProperties>
{noformat} 

Maven doesn't interpolate the buildnumber.  But the value is available at project.getProperties().

  was:
My plugin has a configuration like this:
{quote}
    /**
     * My Properties.
     *
     * @parameter
     */
    private Properties myProperties;
{quote}

When I configure like this:
{quote}
<myProperties>
  <property>
    <name>propertyName1</name>
    <value>${buildnumber}</value> <!-- property injected on maven properties by  http://mojo.codehaus.org/buildnumber-maven-plugin/ -->
  <property>
</myProperties>
{quote}

Maven doesn't interpolate the buildnumber.  But the value is available at project.getProperties().


> Maven is not interpolatin Properties at plugin configuration
> ------------------------------------------------------------
>
>                 Key: MNG-3807
>                 URL: http://jira.codehaus.org/browse/MNG-3807
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Inheritance and Interpolation
>            Reporter: Marvin Froeder
>
> My plugin has a configuration like this:
> {noformat} 
>     /**
>      * My Properties.
>      *
>      * @parameter
>      */
>     private Properties myProperties;
> {noformat} 
> When I configure like this:
> {noformat} 
> <myProperties>
>   <property>
>     <name>propertyName1</name>
>     <value>${buildnumber}</value> <!-- property injected on maven properties by  http://mojo.codehaus.org/buildnumber-maven-plugin/ -->
>   <property>
> </myProperties>
> {noformat} 
> Maven doesn't interpolate the buildnumber.  But the value is available at project.getProperties().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-3807) Maven is not interpolatin Properties at plugin configuration

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MNG-3807:
------------------------------

    Fix Version/s:     (was: 2.1.0-M2)
                   2.2.0-M1

Bump plexus container changes to 2.2, if not 3.0

> Maven is not interpolatin Properties at plugin configuration
> ------------------------------------------------------------
>
>                 Key: MNG-3807
>                 URL: http://jira.codehaus.org/browse/MNG-3807
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Inheritance and Interpolation
>    Affects Versions: 2.0.9, 2.1.0-M1
>            Reporter: Marvin Froeder
>             Fix For: 2.2.0-M1
>
>
> My plugin has a configuration like this:
> {noformat} 
>     /**
>      * My Properties.
>      *
>      * @parameter
>      */
>     private Properties myProperties;
> {noformat} 
> When I configure like this:
> {noformat} 
> <myProperties>
>   <property>
>     <name>propertyName1</name>
>     <value>${buildnumber}</value> <!-- property injected on maven properties by  http://mojo.codehaus.org/buildnumber-maven-plugin/ -->
>   <property>
> </myProperties>
> {noformat} 
> Maven doesn't interpolate the buildnumber.  But the value is available at project.getProperties().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-3807) Maven is not interpolatin Properties at plugin configuration

Posted by "Marvin Froeder (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marvin Froeder updated MNG-3807:
--------------------------------

    Description: 
My plugin has a configuration like this:
{quote}
    /**
     * My Properties.
     *
     * @parameter
     */
    private Properties myProperties;
{quote}

When I configure like this:
{quote}
<myProperties>
  <property>
    <name>propertyName1</name>
    <value>${buildnumber}</value> <!-- property injected on maven properties by  http://mojo.codehaus.org/buildnumber-maven-plugin/ -->
  <property>
</myProperties>
{quote}

Maven doesn't interpolate the buildnumber.  But the value is available at project.getProperties().

  was:
My plugin has a configuration like this:
    /**
     * My Properties.
     *
     * @parameter
     */
    private Properties myProperties;


When I configure like this:
<myProperties>
  <property>
    <name>propertyName1</name>
    <value>${buildnumber}</value> <!-- property injected on maven properties by  http://mojo.codehaus.org/buildnumber-maven-plugin/ -->
  <property>
</myProperties>

Maven doesn't interpolate the buildnumber.  But the value is available at project.getProperties().


> Maven is not interpolatin Properties at plugin configuration
> ------------------------------------------------------------
>
>                 Key: MNG-3807
>                 URL: http://jira.codehaus.org/browse/MNG-3807
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Inheritance and Interpolation
>            Reporter: Marvin Froeder
>
> My plugin has a configuration like this:
> {quote}
>     /**
>      * My Properties.
>      *
>      * @parameter
>      */
>     private Properties myProperties;
> {quote}
> When I configure like this:
> {quote}
> <myProperties>
>   <property>
>     <name>propertyName1</name>
>     <value>${buildnumber}</value> <!-- property injected on maven properties by  http://mojo.codehaus.org/buildnumber-maven-plugin/ -->
>   <property>
> </myProperties>
> {quote}
> Maven doesn't interpolate the buildnumber.  But the value is available at project.getProperties().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MNG-3807) Maven is not interpolatin Properties at plugin configuration

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann closed MNG-3807.
----------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.3.x)
                   3.0-alpha-3
         Assignee: Benjamin Bentmann

Fixed in [r829780|http://svn.apache.org/viewvc?view=revision&revision=829780].

> Maven is not interpolatin Properties at plugin configuration
> ------------------------------------------------------------
>
>                 Key: MNG-3807
>                 URL: http://jira.codehaus.org/browse/MNG-3807
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Inheritance and Interpolation
>    Affects Versions: 2.0.9, 2.1.0-M1
>            Reporter: Marvin Froeder
>            Assignee: Benjamin Bentmann
>             Fix For: 3.0-alpha-3
>
>
> My plugin has a configuration like this:
> {noformat} 
>     /**
>      * My Properties.
>      *
>      * @parameter
>      */
>     private Properties myProperties;
> {noformat} 
> When I configure like this:
> {noformat} 
> <myProperties>
>   <property>
>     <name>propertyName1</name>
>     <value>${buildnumber}</value> <!-- property injected on maven properties by  http://mojo.codehaus.org/buildnumber-maven-plugin/ -->
>   <property>
> </myProperties>
> {noformat} 
> Maven doesn't interpolate the buildnumber.  But the value is available at project.getProperties().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-3807) Maven is not interpolatin Properties at plugin configuration

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=152198#action_152198 ] 

John Casey commented on MNG-3807:
---------------------------------

This is related to the version of the plexus container we're using in maven. With more recent versions, the PropertiesConverter (used to convert XML to a Properties instance for plugin parameter injection) does evaluate embedded expressions. However, as of 1.0-alpha-9 of the plexus container, this new code was not in place.

It seems we have two options for fixing this:

1. create a maintenance branch based on plexus 1.0-alpha-9 and fix the PropertiesConverter there, then release a new revision for use in maven
2. move maven onto a more recent plexus version, which will entail quite a bit of work since the component model has changed in important ways since alpha-9.

My personal opinion is that #2 is preferable if it's reasonably easy to do (not sure on this). This would modernize Maven WRT the plexus container, and enable us to track a little more closely with the progress in plexus in future. However, we could fix the PropertiesConverter itself very quickly, making #1 a much more expedient option.

> Maven is not interpolatin Properties at plugin configuration
> ------------------------------------------------------------
>
>                 Key: MNG-3807
>                 URL: http://jira.codehaus.org/browse/MNG-3807
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Inheritance and Interpolation
>    Affects Versions: 2.0.9, 2.1.0-M1
>            Reporter: Marvin Froeder
>             Fix For: 2.1.0-M2
>
>
> My plugin has a configuration like this:
> {noformat} 
>     /**
>      * My Properties.
>      *
>      * @parameter
>      */
>     private Properties myProperties;
> {noformat} 
> When I configure like this:
> {noformat} 
> <myProperties>
>   <property>
>     <name>propertyName1</name>
>     <value>${buildnumber}</value> <!-- property injected on maven properties by  http://mojo.codehaus.org/buildnumber-maven-plugin/ -->
>   <property>
> </myProperties>
> {noformat} 
> Maven doesn't interpolate the buildnumber.  But the value is available at project.getProperties().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-3807) Maven is not interpolatin Properties at plugin configuration

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey updated MNG-3807:
----------------------------

    Fix Version/s: 2.1.0-M2

> Maven is not interpolatin Properties at plugin configuration
> ------------------------------------------------------------
>
>                 Key: MNG-3807
>                 URL: http://jira.codehaus.org/browse/MNG-3807
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Inheritance and Interpolation
>    Affects Versions: 2.0.9, 2.1.0-M1
>            Reporter: Marvin Froeder
>             Fix For: 2.1.0-M2
>
>
> My plugin has a configuration like this:
> {noformat} 
>     /**
>      * My Properties.
>      *
>      * @parameter
>      */
>     private Properties myProperties;
> {noformat} 
> When I configure like this:
> {noformat} 
> <myProperties>
>   <property>
>     <name>propertyName1</name>
>     <value>${buildnumber}</value> <!-- property injected on maven properties by  http://mojo.codehaus.org/buildnumber-maven-plugin/ -->
>   <property>
> </myProperties>
> {noformat} 
> Maven doesn't interpolate the buildnumber.  But the value is available at project.getProperties().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira