You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/10 15:33:38 UTC
[GitHub] [shardingsphere] TeslaCN opened a new pull request #10299: Correct PostgreSQL Proxy transaction state
TeslaCN opened a new pull request #10299:
URL: https://github.com/apache/shardingsphere/pull/10299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #10299: Correct PostgreSQL Proxy transaction state
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #10299:
URL: https://github.com/apache/shardingsphere/pull/10299#issuecomment-837946778
I've tested it with `sysbench`. It seems worked fine.
https://paste.ubuntu.com/p/DQ32Bz3d5K/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #10299: Correct PostgreSQL Proxy transaction state
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #10299:
URL: https://github.com/apache/shardingsphere/pull/10299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #10299: Correct PostgreSQL Proxy transaction state
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10299:
URL: https://github.com/apache/shardingsphere/pull/10299#issuecomment-838001108
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10299?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10299](https://codecov.io/gh/apache/shardingsphere/pull/10299?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1409a3) into [master](https://codecov.io/gh/apache/shardingsphere/commit/064a8cb15a2204641210213ded80bdc0af268382?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (064a8cb) will **increase** coverage by `0.04%`.
> The diff coverage is `43.58%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/10299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #10299 +/- ##
============================================
+ Coverage 68.22% 68.26% +0.04%
Complexity 684 684
============================================
Files 1706 1706
Lines 29190 29205 +15
Branches 5235 5243 +8
============================================
+ Hits 19914 19937 +23
+ Misses 7734 7721 -13
- Partials 1542 1547 +5
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...acket/generic/PostgreSQLCommandCompletePacket.java](https://codecov.io/gh/apache/shardingsphere/pull/10299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvZ2VuZXJpYy9Qb3N0Z3JlU1FMQ29tbWFuZENvbXBsZXRlUGFja2V0LmphdmE=) | `40.00% <0.00%> (-17.15%)` | `0.00 <0.00> (ø)` | |
| [...xy/frontend/state/impl/CircuitBreakProxyState.java](https://codecov.io/gh/apache/shardingsphere/pull/10299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvc3RhdGUvaW1wbC9DaXJjdWl0QnJlYWtQcm94eVN0YXRlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ntend/mysql/command/MySQLCommandExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvTXlTUUxDb21tYW5kRXhlY3V0ZUVuZ2luZS5qYXZh) | `4.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nd/postgresql/command/query/PostgreSQLCommand.java](https://codecov.io/gh/apache/shardingsphere/pull/10299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9jb21tYW5kL3F1ZXJ5L1Bvc3RncmVTUUxDb21tYW5kLmphdmE=) | `64.70% <0.00%> (-35.30%)` | `0.00 <0.00> (ø)` | |
| [...d/query/binary/bind/PostgreSQLComBindExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/10299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9jb21tYW5kL3F1ZXJ5L2JpbmFyeS9iaW5kL1Bvc3RncmVTUUxDb21CaW5kRXhlY3V0b3IuamF2YQ==) | `11.11% <26.66%> (+0.85%)` | `0.00 <0.00> (ø)` | |
| [...gresql/command/PostgreSQLCommandExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9jb21tYW5kL1Bvc3RncmVTUUxDb21tYW5kRXhlY3V0ZUVuZ2luZS5qYXZh) | `62.50% <66.66%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nd/text/transaction/TransactionBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/10299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3RyYW5zYWN0aW9uL1RyYW5zYWN0aW9uQmFja2VuZEhhbmRsZXIuamF2YQ==) | `64.28% <100.00%> (+2.74%)` | `0.00 <0.00> (ø)` | |
| [.../transaction/TransactionBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/10299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3RyYW5zYWN0aW9uL1RyYW5zYWN0aW9uQmFja2VuZEhhbmRsZXJGYWN0b3J5LmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/proxy/frontend/command/CommandExecutorTask.java](https://codecov.io/gh/apache/shardingsphere/pull/10299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvY29tbWFuZC9Db21tYW5kRXhlY3V0b3JUYXNrLmphdmE=) | `78.43% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...authentication/PostgreSQLAuthenticationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10299/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9hdXRoZW50aWNhdGlvbi9Qb3N0Z3JlU1FMQXV0aGVudGljYXRpb25FbmdpbmUuamF2YQ==) | `96.77% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/shardingsphere/pull/10299/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10299?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10299?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [064a8cb...e1409a3](https://codecov.io/gh/apache/shardingsphere/pull/10299?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org