[GitHub] [superset] rusackas commented on a change in pull request #17634: chore(plugin-chart-pivot-table): Add more descriptive tooltips for sorting [ID-29]

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #17634:
URL: https://github.com/apache/superset/pull/17634#discussion_r761331308



##########
File path: superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx
##########
@@ -254,7 +264,16 @@ const config: ControlPanelConfig = {
                 ['value_z_to_a', t('value descending')],
               ],
               renderTrigger: true,
-              description: t('Order of columns'),
+              description: (
+                <React.Fragment>
+                  <div>{t('Change order of columns.')}</div>
+                  <div>{t('Available sorting modes:')}</div>
+                  <ul>
+                    <li>{t('By key: use columns names as sorting key')}</li>
+                    <li>{t('By value: use metrics values as sorting key')}</li>

Review comment:
       ```suggestion
                       <li>{t('By key: use column names as sorting key')}</li>
                       <li>{t('By value: use metric values as sorting key')}</li>
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org