[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10349: Change `scapedMetricsNameCache` method to support `/`

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #10349:
URL: https://github.com/apache/skywalking/pull/10349#discussion_r1096929521


##########
oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/prometheus/PrometheusMetricConverter.java:
##########
@@ -71,7 +71,7 @@ public String load(final String name) {
 
     public PrometheusMetricConverter(Rule rule, MeterSystem service) {
         this.convert = new MetricConvert(rule, service);
-        this.metricsNameEscapePattern = Pattern.compile("\\.");
+        this.metricsNameEscapePattern = Pattern.compile("[/.]");

Review Comment:
   I am not good at regex, is this testes? Do we have UT for this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org