You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2023/01/14 03:47:10 UTC

[GitHub] [incubator-seatunnel] lightzhao opened a new pull request, #3945: [Bug][Connector-v2][HdfsSink]Fix data loss caused by commit failure.

lightzhao opened a new pull request, #3945:
URL: https://github.com/apache/incubator-seatunnel/pull/3945

   When the hdfs fails, the commit of the hdfs sink should fail, otherwise the data will be lost.
   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   * [ ] If you are contributing the connector code, please check that the following files are updated:
     1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
     2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
     3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
   * [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] TyrantLucifer closed pull request #3945: [Bug][Connector-v2][HdfsSink]Fix data loss caused by commit failure.

Posted by GitBox <gi...@apache.org>.
TyrantLucifer closed pull request #3945: [Bug][Connector-v2][HdfsSink]Fix data loss caused by commit failure.
URL: https://github.com/apache/incubator-seatunnel/pull/3945


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3945: [Bug][Connector-v2][HdfsSink]Fix data loss caused by commit failure.

Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #3945:
URL: https://github.com/apache/incubator-seatunnel/pull/3945#issuecomment-1382664993

   When commit operation failed, it will collect these failed transaction information and try to recommit those at engine point (This is the design idea). So it's meaningless to do these things. I will close this PR, if you have any other suggestion or problem, please reopen it. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] lightzhao commented on pull request #3945: [Bug][Connector-v2][HdfsSink]Fix data loss caused by commit failure.

Posted by GitBox <gi...@apache.org>.
lightzhao commented on PR #3945:
URL: https://github.com/apache/incubator-seatunnel/pull/3945#issuecomment-1382740825

   <img width="958" alt="image" src="https://user-images.githubusercontent.com/40714172/212474546-1cdf35cf-66c7-45c2-ad1f-fbcd4344abee.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3945: [Bug][Connector-v2][HdfsSink]Fix data loss caused by commit failure.

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #3945:
URL: https://github.com/apache/incubator-seatunnel/pull/3945#issuecomment-1384789857

   Hi, this is a problem we should faced, in two phase commit, we think the second phase always should success, if we abort it, the two phase commit can't make sure exactly-once. So if second phase failed, in zeta engine, we will recommit it again after job restarted. But flink engine can't support recommit in flink 1.13.6, so user should handle it by themself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] lightzhao commented on pull request #3945: [Bug][Connector-v2][HdfsSink]Fix data loss caused by commit failure.

Posted by GitBox <gi...@apache.org>.
lightzhao commented on PR #3945:
URL: https://github.com/apache/incubator-seatunnel/pull/3945#issuecomment-1382739354

   > When commit operation failed, it will collect these failed transaction information and try to recommit those at engine point (This is the design idea). So it's meaningless to do these things. I will close this PR, if you have any other suggestion or problem, please reopen it. Thanks!
   
   @TyrantLucifer The problem is that on the Flink engine, the commit failure will result in the loss of kafka consumption data, which is not successfully written on the sink side, but the kafka consumption has been committed successfully.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] lightzhao commented on pull request #3945: [Bug][Connector-v2][HdfsSink]Fix data loss caused by commit failure.

Posted by GitBox <gi...@apache.org>.
lightzhao commented on PR #3945:
URL: https://github.com/apache/incubator-seatunnel/pull/3945#issuecomment-1383364332

   @TyrantLucifer I don't seem to have permission to re-open this PR. Can you re-open it and invite others to watch this PR together? The test found that it is a bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org