You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "harinirajendran (via GitHub)" <gi...@apache.org> on 2023/11/20 22:08:21 UTC
[PR] MINOR: Increase the delta for a flaky quota test [kafka]
harinirajendran opened a new pull request, #14805:
URL: https://github.com/apache/kafka/pull/14805
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Increase the delta for a flaky quota test [kafka]
Posted by "harinirajendran (via GitHub)" <gi...@apache.org>.
harinirajendran commented on PR #14805:
URL: https://github.com/apache/kafka/pull/14805#issuecomment-1820596648
> @harinirajendran , thanks for the PR. Could you explain more what this test is trying to do, and why we originally set it to 7? I know it's not written by you, but after you investigating this test, why it is 7? And why changing to 8 fixes it? Just because you saw there's a flaky test failure message and changing to 8 can fix it? Then, if some day after you changing to 8, and it failed again, should we change to 9 then? then 10, 11... ? Please try to persuade me your rational behind this change. Thank you.
@showuon : Thank you for the review. The rationale for the change is as follows. This test used to be flaky in our proprietary fork with the same assert exception. The delta was bumped up from 7 to 8, 2 years ago and since then it has been fine. Now this test is behaving flaky in our public https://github.com/confluentinc/kafka repo. So, I am just applying the same fix here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Increase the delta for a flaky quota test [kafka]
Posted by "harinirajendran (via GitHub)" <gi...@apache.org>.
harinirajendran commented on PR #14805:
URL: https://github.com/apache/kafka/pull/14805#issuecomment-1821167150
We decided to fix this flaky test in our fork for now. So, closing the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Increase the delta for a flaky quota test [kafka]
Posted by "harinirajendran (via GitHub)" <gi...@apache.org>.
harinirajendran closed pull request #14805: MINOR: Increase the delta for a flaky quota test
URL: https://github.com/apache/kafka/pull/14805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org