[GitHub] [airflow] potiuk commented on a change in pull request #14535: Fix: Mysql 5.7 id utf8mb3

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #14535:
URL: https://github.com/apache/airflow/pull/14535#discussion_r642560346



##########
File path: airflow/migrations/versions/e3a246e0dc1_current_schema.py
##########
@@ -38,6 +38,8 @@
 depends_on = None
 
 
+print(COLLATION_ARGS)

Review comment:
       I guess we shoudl remove it ?

##########
File path: airflow/migrations/versions/bbf4a7ad0465_remove_id_column_from_xcom.py
##########
@@ -110,7 +110,8 @@ def upgrade():
             bop.drop_index('idx_xcom_dag_task_date')
             # mssql doesn't allow primary keys with nullable columns
             if conn.dialect.name != 'mssql':
-                bop.create_primary_key('pk_xcom', ['dag_id', 'task_id', 'key', 'execution_date'])
+                #bop.create_primary_key('pk_xcom', ['dag_id', 'task_id', 'key', 'execution_date'])
+                bop.create_primary_key('pk_xcom', ['dag_id', 'task_id', 'key'])

Review comment:
       Why this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org