You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/12 08:35:43 UTC
[GitHub] [apisix] imjoey commented on a change in pull request #6039: feat: support hide the authentication header in basic-auth with a config
imjoey commented on a change in pull request #6039:
URL: https://github.com/apache/apisix/pull/6039#discussion_r782815357
##########
File path: docs/en/latest/plugins/basic-auth.md
##########
@@ -39,10 +39,18 @@ For more information on Basic authentication, refer to [Wiki](https://en.wikiped
## Attributes
-| Name | Type | Requirement | Default | Valid | Description |
-| -------- | ------ | ----------- | ------- | ----- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| username | string | required | | | Different `consumer` should have different value which is unique. When different `consumer` use a same `username`, a request matching exception would be raised. |
-| password | string | required | | | the user's password |
+For consumer side:
+
+| Name | Type | Requirement | Default | Valid | Description |
+| -------- | ------ | ----------- | ------- | ----- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| username | string | required | | | Different `consumer` should have different value which is unique. When different `consumer` use a same `username`, a request matching exception would be raised. |
+| password | string | required | | | the user's password |
Review comment:
@mangoGoForward IMHO there's no need to change this. How about revert it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org