You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "moonming (via GitHub)" <gi...@apache.org> on 2026/07/28 02:45:02 UTC
[PR] fix(ci): drop the canonical assertion for a page Docusaurus no longer builds [apisix-website]
moonming opened a new pull request, #2081:
URL: https://github.com/apache/apisix-website/pull/2081
## The failure
The wave-3 deploy (`ed400cdc9`) failed at **Assert canonical contract**:
```
grep: website/build/docs/apisix/plugins/cors/index.html: No such file or directory
```
That step greps the version-less page, but wave 3 gave the newest release an explicit version path precisely so Docusaurus would stop emitting the version-less pages — the Astro build owns them now. I changed what that build produces and missed that an existing assertion depended on it.
**Blast radius:** the step runs before the publish, so the deploy aborted rather than shipping a broken tree — `asf-site` still holds the previous build and the live site is intact (verified: homepage, blog, learning-center, comparisons all serving normally). But master has not been able to deploy since that merge, so wave 3 is not live yet.
## The fix
Only the version-less half of the assertion is removed. The versioned-page half — one canonical per page, pointing at the version-less URL — stays exactly where it is.
Nothing is lost in coverage: the cross-site canonical for the version-less pages is already asserted **after the overlay**, for both locales, against the files that actually ship:
```bash
for f in website/build/docs/apisix/plugins/cors/index.html \
website/build/zh/docs/apisix/plugins/cors/index.html; do
test "$(grep -o 'rel="canonical"' "$f" | wc -l)" -eq 1
grep -q 'rel="canonical" href="https://docs.api7.ai/hub/cors"' "$f"
done
```
That is a stronger check than the one being removed — it covers both locales and runs against the published output rather than an intermediate build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ci): drop the canonical assertion for a page Docusaurus no longer builds [apisix-website]
Posted by "moonming (via GitHub)" <gi...@apache.org>.
moonming merged PR #2081:
URL: https://github.com/apache/apisix-website/pull/2081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org