[GitHub] [spark] MaxGekk commented on pull request #28787: [SPARK-31959][SQL] Fix Gregorian-Julian micros rebasing while switching standard time zone offset

[GitBox <gi...@apache.org>]

MaxGekk commented on pull request #28787:
URL: https://github.com/apache/spark/pull/28787#issuecomment-642390800


   The build https://github.com/apache/spark/pull/28787#issuecomment-642292477 failed on the assert for JDK calls:
   ```scala
         val ldt = LocalDateTime.of(1945, 11, 18, 1, 30, 0)
         val earlierMicros = instantToMicros(ldt.atZone(hkZid).withEarlierOffsetAtOverlap().toInstant)
         val laterMicros = instantToMicros(ldt.atZone(hkZid).withLaterOffsetAtOverlap().toInstant)
         assert(earlierMicros + MICROS_PER_HOUR === laterMicros)
   ```
   because jenkins uses "old" JDK:
   ```
   JENKINS_MASTER_HOSTNAME=amp-jenkins-master
   JAVA_HOME=/usr/java/jdk1.8.0_191
   ```
   which has an outdated time zone database, see https://bugs.openjdk.java.net/browse/JDK-8228469
   ```
        Hong Kong's 1941-06-15 spring-forward transition was at 03:00, not
        03:30. Its 1945 transition from JST to HKT was on 11-18 at 02:00,
        not 09-15 at 00:00. In 1946 its spring-forward transition was on
        04-21 at 00:00, not the previous day at 03:30. From 1946 through
        1952 its fall-back transitions occurred at 04:30, not at 03:30.
        In 1947 its fall-back transition was on 11-30, not 12-30.
        (Thanks to P Chan.)
   ```
   @cloud-fan @HyukjinKwon @dongjoon-hyun @srowen Can we upgrade JDK on jenkins machines?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org