[jira] [Commented] (FLINK-8399) Use independent configurations for the different timeouts in slot manager

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319856#comment-16319856 ] 

ASF GitHub Bot commented on FLINK-8399:
---------------------------------------

GitHub user shuai-xu opened a pull request:

    https://github.com/apache/flink/pull/5271

    [FLINK-8399] [runtime] use independent configurations for the different timeouts in slot manager

    
    ## What is the purpose of the change
    
    *This pull request separate the timeouts for slot request to task manager, slot request to be discarded and task manager to be released in slot manager to three different configurations.*
    
    
    ## Brief change log
    
    *(for example:)*
      - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
      - *Deployments RPC transmits only the blob storage reference*
      - *TaskManagers retrieve the TaskInfo from the blob cache*
    
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shuai-xu/flink jira-8399

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5271.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5271
    
----
commit f7024439ead5e3848c705659bfe221b8ce50f154
Author: shuai.xus <sh...@...>
Date:   2018-01-10T07:43:20Z

    [FLINK-8399] [runtime] use independent configurations for the different timeouts in slot manager

----


> Use independent configurations for the different timeouts in slot manager
> -------------------------------------------------------------------------
>
>                 Key: FLINK-8399
>                 URL: https://issues.apache.org/jira/browse/FLINK-8399
>             Project: Flink
>          Issue Type: Bug
>          Components: Cluster Management
>    Affects Versions: 1.5.0
>            Reporter: shuai.xu
>            Assignee: shuai.xu
>              Labels: flip-6
>
> There are three parameter in slot manager to indicate the timeout for slot request to task manager, slot request to be discarded and task manager to be released. But now they all come from the value of AkkaOptions.ASK_TIMEOUT, need to use independent configurations for them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)