You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/09 02:29:32 UTC

[GitHub] [arrow] bkietz commented on a change in pull request #11887: ARROW-15012: [C++] fixes for msvc environment

bkietz commented on a change in pull request #11887:
URL: https://github.com/apache/arrow/pull/11887#discussion_r765387997



##########
File path: cpp/src/arrow/util/macros.h
##########
@@ -97,6 +97,17 @@
 
 #endif  // ifndef NULLPTR
 
+// ----------------------------------------------------------------------
+// microsoft source-code annotation language
+
+#ifndef _In_z_
+#define _In_z_
+#endif
+
+#ifndef _Out_writes_opt_
+#define _Out_writes_opt_(size)

Review comment:
       I think modifying the codebase to support a static analyzer is a fairly disruptive change and the benefit should be carefully weighed against the maintenance overhead of these annotations. Could you please note on the JIRA why PREfast is a compelling analyzer to support?
   
   I'm also curious about the reasoning for the specific locations where the annotations were added and whether PREfast could be profitably added to our CI suite




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org