[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10402: style: add fade transition to bottom border on navbar menu items

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #10402:
URL: https://github.com/apache/incubator-superset/pull/10402#discussion_r459189841



##########
File path: superset-frontend/src/components/Menu/Menu.jsx
##########
@@ -59,6 +59,28 @@ const StyledHeader = styled.header`
     flex-direction: column;
     justify-content: center;
   }
+
+  .navbar-nav > li > a {
+    &:after {
+      content: '';
+      position: absolute;
+      bottom: -3px;
+      left: 0;
+      width: 100%;
+      height: 3px;
+      background-color: #20a7c9;

Review comment:
       let's use the theme's colors `@superset-ui/style`, check it out here: https://github.com/apache-superset/superset-ui/blob/master/packages/superset-ui-style/src/index.ts#L23
   
   Above you can `import styled, { supersetTheme } from '@superset-ui/style';` and use `supersetTheme.colors.primary.base `




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org