You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Vyacheslav Daradur <da...@gmail.com> on 2018/11/22 12:47:14 UTC
How to deprecate unused Ignite's system property properly?
(IGNITE-7441 Drop IGNITE_SERVICES_COMPATIBILITY_MODE system property)
Hi, Igniters!
Here is Jira issue [1] to drop one of Ignite's system property
"IGNITE_SERVICES_COMPATIBILITY_MODE" because it is not used.
I looked through git history and related Jira issues, the common conclusions:
- the property was introduced in Ignite 1.7 within the task [2] to use
LazyServiceConfiguration with premarshaled services instance;
- Ignite 2.* was released which is incompatible with 1.*;
- since Ignite 2.3 the property is completely ignored after introduced
batch deployment mode [3];
Looks like we can just remove the property without introducing any
compatibility issues.
Also, related node attribute 'ATTR_SERVICES_COMPATIBILITY_MODE' can be
safely removed.
So, my question is: can I just remove following properties or I should
deprecate them and remove all usages?
IgniteSystemProperties#IGNITE_SERVICES_COMPATIBILITY_MODE
IgniteNodeAttributes#ATTR_SERVICES_COMPATIBILITY_MODE
[1] https://issues.apache.org/jira/browse/IGNITE-7441
[2] https://issues.apache.org/jira/browse/IGNITE-3056
[3] https://issues.apache.org/jira/browse/IGNITE-5145
--
Best Regards, Vyacheslav D.
Re: How to deprecate unused Ignite's system property properly?
(IGNITE-7441 Drop IGNITE_SERVICES_COMPATIBILITY_MODE system property)
Posted by Vyacheslav Daradur <da...@gmail.com>.
Denis, thank you for the reply.
I prepared PR [1] for the task [2].
Tests look good to me (the same failures in comparison with master branch).
Could you review the PR please (it should not take a lot of time)?
[1] https://github.com/apache/ignite/pull/5482
[2] https://issues.apache.org/jira/browse/IGNITE-7441
On Thu, Nov 22, 2018 at 5:58 PM Denis Mekhanikov <dm...@gmail.com> wrote:
>
> Vyacheslav,
>
> You are right. This property is not used anywhere, so you can safely remove
> it.
> I don't think, there is any need in deprecation. You can just go ahead and
> drop it,
> since it doesn't have any effect.
>
> Denis
>
> чт, 22 нояб. 2018 г. в 15:47, Vyacheslav Daradur <da...@gmail.com>:
>
> > Hi, Igniters!
> >
> > Here is Jira issue [1] to drop one of Ignite's system property
> > "IGNITE_SERVICES_COMPATIBILITY_MODE" because it is not used.
> >
> > I looked through git history and related Jira issues, the common
> > conclusions:
> > - the property was introduced in Ignite 1.7 within the task [2] to use
> > LazyServiceConfiguration with premarshaled services instance;
> > - Ignite 2.* was released which is incompatible with 1.*;
> > - since Ignite 2.3 the property is completely ignored after introduced
> > batch deployment mode [3];
> >
> > Looks like we can just remove the property without introducing any
> > compatibility issues.
> > Also, related node attribute 'ATTR_SERVICES_COMPATIBILITY_MODE' can be
> > safely removed.
> >
> > So, my question is: can I just remove following properties or I should
> > deprecate them and remove all usages?
> > IgniteSystemProperties#IGNITE_SERVICES_COMPATIBILITY_MODE
> > IgniteNodeAttributes#ATTR_SERVICES_COMPATIBILITY_MODE
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-7441
> > [2] https://issues.apache.org/jira/browse/IGNITE-3056
> > [3] https://issues.apache.org/jira/browse/IGNITE-5145
> >
> > --
> > Best Regards, Vyacheslav D.
> >
--
Best Regards, Vyacheslav D.
Re: How to deprecate unused Ignite's system property properly?
(IGNITE-7441 Drop IGNITE_SERVICES_COMPATIBILITY_MODE system property)
Posted by Denis Mekhanikov <dm...@gmail.com>.
Vyacheslav,
You are right. This property is not used anywhere, so you can safely remove
it.
I don't think, there is any need in deprecation. You can just go ahead and
drop it,
since it doesn't have any effect.
Denis
чт, 22 нояб. 2018 г. в 15:47, Vyacheslav Daradur <da...@gmail.com>:
> Hi, Igniters!
>
> Here is Jira issue [1] to drop one of Ignite's system property
> "IGNITE_SERVICES_COMPATIBILITY_MODE" because it is not used.
>
> I looked through git history and related Jira issues, the common
> conclusions:
> - the property was introduced in Ignite 1.7 within the task [2] to use
> LazyServiceConfiguration with premarshaled services instance;
> - Ignite 2.* was released which is incompatible with 1.*;
> - since Ignite 2.3 the property is completely ignored after introduced
> batch deployment mode [3];
>
> Looks like we can just remove the property without introducing any
> compatibility issues.
> Also, related node attribute 'ATTR_SERVICES_COMPATIBILITY_MODE' can be
> safely removed.
>
> So, my question is: can I just remove following properties or I should
> deprecate them and remove all usages?
> IgniteSystemProperties#IGNITE_SERVICES_COMPATIBILITY_MODE
> IgniteNodeAttributes#ATTR_SERVICES_COMPATIBILITY_MODE
>
> [1] https://issues.apache.org/jira/browse/IGNITE-7441
> [2] https://issues.apache.org/jira/browse/IGNITE-3056
> [3] https://issues.apache.org/jira/browse/IGNITE-5145
>
> --
> Best Regards, Vyacheslav D.
>