You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Nigel Daley (JIRA)" <ji...@apache.org> on 2008/03/05 05:59:40 UTC
[jira] Created: (HADOOP-2939) Make the Hudson patch process an
executable ant target
Make the Hudson patch process an executable ant target
------------------------------------------------------
Key: HADOOP-2939
URL: https://issues.apache.org/jira/browse/HADOOP-2939
Project: Hadoop Core
Issue Type: Improvement
Components: test
Reporter: Nigel Daley
Priority: Minor
The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2939) Make the Hudson patch process an
executable ant target
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580647#action_12580647 ]
Raghu Angadi commented on HADOOP-2939:
--------------------------------------
> Its better if -Dpatch.file is optional, i.e. patch might already be applied.
ok, it needs a base for comparision. So it needs a base. Very useful ant target. I would say (at least optionally) ignore 'unknown' files from svn.
> Make the Hudson patch process an executable ant target
> ------------------------------------------------------
>
> Key: HADOOP-2939
> URL: https://issues.apache.org/jira/browse/HADOOP-2939
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: HADOOP-2939.patch, HADOOP-2939.patch, HADOOP-2939.patch
>
>
> The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2939) Make the Hudson patch process an
executable ant target
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-2939:
--------------------------------
Attachment: HADOOP-2939.patch
Updated patch.
> Make the Hudson patch process an executable ant target
> ------------------------------------------------------
>
> Key: HADOOP-2939
> URL: https://issues.apache.org/jira/browse/HADOOP-2939
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: HADOOP-2939.patch, HADOOP-2939.patch
>
>
> The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-2939) Make the Hudson patch process an
executable ant target
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley resolved HADOOP-2939.
---------------------------------
Resolution: Fixed
I committed this.
> Make the Hudson patch process an executable ant target
> ------------------------------------------------------
>
> Key: HADOOP-2939
> URL: https://issues.apache.org/jira/browse/HADOOP-2939
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: HADOOP-2939.patch, HADOOP-2939.patch, HADOOP-2939.patch
>
>
> The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-2939) Make the Hudson patch
process an executable ant target
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580647#action_12580647 ]
rangadi edited comment on HADOOP-2939 at 3/19/08 11:18 PM:
----------------------------------------------------------------
> Its better if -Dpatch.file is optional, i.e. patch might already be applied.
ok, it needs a base for comparision. So it needs a patch. Very useful ant target. I would say we could ignore (at least optionally) the 'unknown' entries from svn.
was (Author: rangadi):
> Its better if -Dpatch.file is optional, i.e. patch might already be applied.
ok, it needs a base for comparision. So it needs a base. Very useful ant target. I would say (at least optionally) ignore 'unknown' files from svn.
> Make the Hudson patch process an executable ant target
> ------------------------------------------------------
>
> Key: HADOOP-2939
> URL: https://issues.apache.org/jira/browse/HADOOP-2939
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: HADOOP-2939.patch, HADOOP-2939.patch, HADOOP-2939.patch
>
>
> The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2939) Make the Hudson patch process an
executable ant target
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580645#action_12580645 ]
Raghu Angadi commented on HADOOP-2939:
--------------------------------------
I am trying this. At my first attempt, I got {noformat}[...]
[exec] ERROR: can't run in a workspace that contains modifications
[...]{noformat} I guess because : {noformat}
cdev6016:hadoop> svn status
? tmp{noformat}
It is very common for developers to have a few 'unknown' files in the workspace. Its better if -Dpatch.file is optional, i.e. patch might already be applied. Alternately we can enforce clean checkout only when -Dpatch.file is specified.
> Make the Hudson patch process an executable ant target
> ------------------------------------------------------
>
> Key: HADOOP-2939
> URL: https://issues.apache.org/jira/browse/HADOOP-2939
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: HADOOP-2939.patch, HADOOP-2939.patch, HADOOP-2939.patch
>
>
> The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2939) Make the Hudson patch process an
executable ant target
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579079#action_12579079 ]
Hadoop QA commented on HADOOP-2939:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12377953/HADOOP-2939.patch
against trunk revision 619744.
@author -1. The patch appears to contain 6 @author tags which the Hadoop community has agreed to not allow in code contributions.
tests included +1. The patch appears to include 16 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1975/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1975/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1975/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1975/console
This message is automatically generated.
> Make the Hudson patch process an executable ant target
> ------------------------------------------------------
>
> Key: HADOOP-2939
> URL: https://issues.apache.org/jira/browse/HADOOP-2939
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: HADOOP-2939.patch, HADOOP-2939.patch
>
>
> The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2939) Make the Hudson patch process an
executable ant target
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579891#action_12579891 ]
Hudson commented on HADOOP-2939:
--------------------------------
Integrated in Hadoop-trunk #432 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/432/])
> Make the Hudson patch process an executable ant target
> ------------------------------------------------------
>
> Key: HADOOP-2939
> URL: https://issues.apache.org/jira/browse/HADOOP-2939
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: HADOOP-2939.patch, HADOOP-2939.patch, HADOOP-2939.patch
>
>
> The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2939) Make the Hudson patch process an
executable ant target
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-2939:
----------------------------------
Status: Open (was: Patch Available)
> Make the Hudson patch process an executable ant target
> ------------------------------------------------------
>
> Key: HADOOP-2939
> URL: https://issues.apache.org/jira/browse/HADOOP-2939
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: HADOOP-2939.patch, HADOOP-2939.patch
>
>
> The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2939) Make the Hudson patch process an
executable ant target
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576068#action_12576068 ]
Nigel Daley commented on HADOOP-2939:
-------------------------------------
The attached patch file was provided by Ramya R.
This creates a new ant target that is run as follows:
ant test-patch -Dpatch.file="<PATCH_FILE>" -Dfindbugs.home="<FINDBUGS_HOME>" -Dforrest.home="<FORREST_HOME>" [-Dscratch.dir="<SCRATCH_DIR>"]
By default : SCRATCH_DIR="$HOME/tmp"
SVN="svn" (can be set by svn.cmd)
GREP="grep" (can be set by patch.cmd)
PATCH="patch" (can be set by patch.cmd)
When run as the patch process on Hudson, the script is run as follows:
sh hudsonBuildHadoopPatch.sh [-c <PATCH_DIR>] [-s <SUPPORT_DIR>] [-t <TRIGGER_BUILD>] [-j <JIRA_PASSWD>]
All the usage messages are incorporated at appropriate places and checking for existence of files or directory has also been included.
> Make the Hudson patch process an executable ant target
> ------------------------------------------------------
>
> Key: HADOOP-2939
> URL: https://issues.apache.org/jira/browse/HADOOP-2939
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Attachments: HADOOP-2939.patch
>
>
> The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2939) Make the Hudson patch process an
executable ant target
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-2939:
--------------------------------
Attachment: HADOOP-2939.patch
> Make the Hudson patch process an executable ant target
> ------------------------------------------------------
>
> Key: HADOOP-2939
> URL: https://issues.apache.org/jira/browse/HADOOP-2939
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Priority: Minor
> Attachments: HADOOP-2939.patch
>
>
> The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-2939) Make the Hudson patch process an
executable ant target
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley reassigned HADOOP-2939:
-----------------------------------
Assignee: Nigel Daley
> Make the Hudson patch process an executable ant target
> ------------------------------------------------------
>
> Key: HADOOP-2939
> URL: https://issues.apache.org/jira/browse/HADOOP-2939
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Attachments: HADOOP-2939.patch
>
>
> The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2939) Make the Hudson patch process an
executable ant target
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579639#action_12579639 ]
Nigel Daley commented on HADOOP-2939:
-------------------------------------
This fails the "@author" check because the patch contains the string "@author" in it's grep for this token in the patches it will test :-)
This patch is ready to commit.
> Make the Hudson patch process an executable ant target
> ------------------------------------------------------
>
> Key: HADOOP-2939
> URL: https://issues.apache.org/jira/browse/HADOOP-2939
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: HADOOP-2939.patch, HADOOP-2939.patch
>
>
> The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2939) Make the Hudson patch process an
executable ant target
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-2939:
--------------------------------
Attachment: HADOOP-2939.patch
Updated patch that applies cleanly.
> Make the Hudson patch process an executable ant target
> ------------------------------------------------------
>
> Key: HADOOP-2939
> URL: https://issues.apache.org/jira/browse/HADOOP-2939
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: HADOOP-2939.patch, HADOOP-2939.patch, HADOOP-2939.patch
>
>
> The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2939) Make the Hudson patch process an
executable ant target
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-2939:
--------------------------------
Fix Version/s: 0.17.0
Status: Patch Available (was: Open)
> Make the Hudson patch process an executable ant target
> ------------------------------------------------------
>
> Key: HADOOP-2939
> URL: https://issues.apache.org/jira/browse/HADOOP-2939
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: HADOOP-2939.patch, HADOOP-2939.patch
>
>
> The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2939) Make the Hudson patch process an
executable ant target
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579643#action_12579643 ]
Chris Douglas commented on HADOOP-2939:
---------------------------------------
There are two sections of the diff that don't seem related:
{noformat}
@@ -178,7 +184,6 @@
<mkdir dir="${build.webapps}/job/WEB-INF"/>
<mkdir dir="${build.webapps}/dfs/WEB-INF"/>
<mkdir dir="${build.webapps}/datanode/WEB-INF"/>
- <mkdir dir="${build.webapps}/history/WEB-INF"/>
<mkdir dir="${build.examples}"/>
<mkdir dir="${build.anttasks}"/>
<mkdir dir="${build.dir}/c++"/>
@@ -274,13 +279,6 @@
</jsp-compile>
<jsp-compile
- uriroot="${src.webapps}/history"
- outputdir="${build.src}"
- package="org.apache.hadoop.mapred"
- webxml="${build.webapps}/history/WEB-INF/web.xml">
- </jsp-compile>
-
- <jsp-compile
uriroot="${src.webapps}/datanode"
outputdir="${build.src}"
package="org.apache.hadoop.dfs"
{noformat}
This was part of HADOOP-2901, which was recently committed; the patch no longer applies cleanly. Could you regenerate it?
> Make the Hudson patch process an executable ant target
> ------------------------------------------------------
>
> Key: HADOOP-2939
> URL: https://issues.apache.org/jira/browse/HADOOP-2939
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.17.0
>
> Attachments: HADOOP-2939.patch, HADOOP-2939.patch
>
>
> The automatic Hadoop patch testing does some fairly intricate processing. It would be useful if this was exposed to the developers as an ant target.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.