You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "agam-99 (via GitHub)" <gi...@apache.org> on 2026/05/27 14:37:10 UTC
[PR] GOBBLIN-2263: Refresh DagAction latency anchor [gobblin]
agam-99 opened a new pull request, #4198:
URL: https://github.com/apache/gobblin/pull/4198
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2263
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
- Refreshes `dagAction.launch.storeInsertTimeMillis` on each job's `JobSpec` immediately before executor submission, using the current DagAction lease timestamp instead of the original flow LAUNCH timestamp.
- Threads the current `LeaseParams` through launch, reevaluate, and resume DagProc submission paths so downstream jobs in multi-hop DAGs measure their own DagAction queueing latency rather than elapsed DAG runtime.
- Updates serialized job properties alongside the Typesafe config so `GaaSJobObservabilityEvent` and GridGateway metric emission observe the same fresh anchor.
- Uses binary UTF-8 collations for orchestration identifier tables so non-ASCII flow/job identifiers can be compared safely; `dag_node_id`/`parent_dag_id` use `utf8_bin` to stay within MySQL index limits.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
- Added `DagProcUtilsTest.testSubmitJobToExecutorReplacesStaleStoreInsertTimeMillis` to verify stale anchors are replaced in both `JobSpec` config and properties before submission.
- Added `ReevaluateDagProcTest.testCurrentJobToRunReplacesStaleStoreInsertTimeMillis` to cover the downstream REEVALUATE path.
- `JAVA_HOME="/Library/Java/JavaVirtualMachines/jdk1.8.0_282-msft.jdk/Contents/Home" ./gradlew :gobblin-service:compileJava :gobblin-service:compileTestJava`
- `JAVA_HOME="/Library/Java/JavaVirtualMachines/jdk1.8.0_282-msft.jdk/Contents/Home" ./gradlew :gobblin-service:test --tests "org.apache.gobblin.service.modules.orchestration.proc.DagProcUtilsTest"`
- Attempted `JAVA_HOME="/Library/Java/JavaVirtualMachines/jdk1.8.0_282-msft.jdk/Contents/Home" ./gradlew :gobblin-service:test --tests "org.apache.gobblin.service.modules.orchestration.proc.DagProcUtilsTest" --tests "org.apache.gobblin.service.modules.orchestration.proc.ReevaluateDagProcTest" --tests "org.apache.gobblin.service.modules.orchestration.proc.LaunchDagProcTest"`; the suite compiled but failed during `TestMetastoreDatabaseFactory` setup because Docker/Testcontainers is not available in this environment.
- `git diff --check`
- `mint build` not applicable: this checkout is not a LinkedIn multiproduct directory.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GOBBLIN-2263: Refresh DagAction latency anchor [gobblin]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4198:
URL: https://github.com/apache/gobblin/pull/4198#issuecomment-4590473036
## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/4198?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 51.23%. Comparing base ([`26406a8`](https://app.codecov.io/gh/apache/gobblin/commit/26406a863688e289063e92bd421bf866f84e5586?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5bc0ce0`](https://app.codecov.io/gh/apache/gobblin/commit/5bc0ce09d12c12910ca07877f7fd5dfe25d4a210?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 12 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4198 +/- ##
============================================
+ Coverage 43.26% 51.23% +7.96%
- Complexity 2583 6235 +3652
============================================
Files 516 1102 +586
Lines 22087 43000 +20913
Branches 2505 4841 +2336
============================================
+ Hits 9557 22032 +12475
- Misses 11566 19132 +7566
- Partials 964 1836 +872
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/gobblin/pull/4198?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GOBBLIN-2263: Refresh DagAction latency anchor [gobblin]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #4198:
URL: https://github.com/apache/gobblin/pull/4198#discussion_r3332304593
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProcUtils.java:
##########
@@ -166,6 +189,22 @@ public static void submitJobToExecutor(DagManagementStateStore dagManagementStat
log.info("Submitted job {} for dagId {}", DagUtils.getJobName(dagNode), dagId);
}
+ static void stampDagActionStoreInsertTimeMillis(JobSpec jobSpec, long storeInsertTimeMillis) {
+ Config jobConfig = jobSpec.getConfig().withoutPath(ConfigurationKeys.DAG_ACTION_LAUNCH_STORE_INSERT_TIME_MILLIS_KEY);
+ if (storeInsertTimeMillis != DagActionStore.LeaseParams.UNKNOWN_STORE_INSERT_TIME_MILLIS) {
+ jobConfig = jobConfig.withValue(ConfigurationKeys.DAG_ACTION_LAUNCH_STORE_INSERT_TIME_MILLIS_KEY,
+ ConfigValueFactory.fromAnyRef(storeInsertTimeMillis));
+ }
+ jobSpec.setConfig(jobConfig);
+ jobSpec.setConfigAsProperties(ConfigUtils.configToProperties(jobConfig));
+ }
Review Comment:
`stampDagActionStoreInsertTimeMillis` always removes `dagAction.launch.storeInsertTimeMillis` via `withoutPath(...)` even when the provided `storeInsertTimeMillis` is `UNKNOWN`. Because the no-arg `submitJobToExecutor(...)`/`submitNextNodes(...)` overloads pass `UNKNOWN`, callers without lease metadata will now *drop* any pre-existing timestamp in the `JobSpec`, changing behavior and potentially removing the latency anchor unexpectedly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GOBBLIN-2263: Refresh DagAction latency anchor [gobblin]
Posted by "Blazer-007 (via GitHub)" <gi...@apache.org>.
Blazer-007 merged PR #4198:
URL: https://github.com/apache/gobblin/pull/4198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org