You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/08 16:24:27 UTC
[GitHub] [spark] khalidmammadov opened a new pull request, #37441: [WIP] Add doc string to DataFrame union and unionAll
khalidmammadov opened a new pull request, #37441:
URL: https://github.com/apache/spark/pull/37441
Adding examples and parameters description to union and unionAll
### What changes were proposed in this pull request?
Documentation enhancements
### Why are the changes needed?
Help user to understand functions
### Does this PR introduce _any_ user-facing change?
Yes, improves documentation
### How was this patch tested?
unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] khalidmammadov commented on pull request #37441: [SPARK-40009][PYTHON][DOCS] Add doc string to DataFrame union and unionAll
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on PR #37441:
URL: https://github.com/apache/spark/pull/37441#issuecomment-1208475446
@HyukjinKwon @srowen please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #37441: [SPARK-40009][PYTHON][DOCS] Add missing doc string info to DataFrame API
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #37441:
URL: https://github.com/apache/spark/pull/37441#issuecomment-1216040609
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37441: [SPARK-40009][PYTHON][DOCS] Add doc string to DataFrame union and unionAll
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37441:
URL: https://github.com/apache/spark/pull/37441#issuecomment-1208590469
Yeah can we fix the whole file instead of one API alone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] khalidmammadov commented on pull request #37441: [SPARK-40009][PYTHON][DOCS] Add doc string to DataFrame union and unionAll
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on PR #37441:
URL: https://github.com/apache/spark/pull/37441#issuecomment-1214219780
@HyukjinKwon @srowen please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] khalidmammadov commented on pull request #37441: [SPARK-40009][PYTHON][DOCS] Add doc string to DataFrame union and unionAll
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on PR #37441:
URL: https://github.com/apache/spark/pull/37441#issuecomment-1208911768
Sure, will work on whole file and revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37441: [SPARK-40009][PYTHON][DOCS] Add doc string to DataFrame union and unionAll
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #37441:
URL: https://github.com/apache/spark/pull/37441#discussion_r940818045
##########
python/pyspark/sql/dataframe.py:
##########
@@ -2520,6 +2550,38 @@ def unionAll(self, other: "DataFrame") -> "DataFrame":
(that does deduplication of elements), use this function followed by :func:`distinct`.
Also as standard in SQL, this function resolves columns by position (not by name).
+
+ Note: This is identical to :func:`union` function
Review Comment:
Let's just probably mention that it's an alias, and remove Examples section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #37441: [SPARK-40009][PYTHON][DOCS] Add missing doc string info to DataFrame API
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #37441: [SPARK-40009][PYTHON][DOCS] Add missing doc string info to DataFrame API
URL: https://github.com/apache/spark/pull/37441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37441: [SPARK-40009][PYTHON][DOCS] Add doc string to DataFrame union and unionAll
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37441:
URL: https://github.com/apache/spark/pull/37441#issuecomment-1208589334
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37441: [SPARK-40009][PYTHON][DOCS] Add doc string to DataFrame union and unionAll
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37441:
URL: https://github.com/apache/spark/pull/37441#issuecomment-1208830270
BTW thanks for working on this @khalidmammadov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] khalidmammadov commented on pull request #37441: [SPARK-40009][PYTHON][DOCS] Add missing doc string info to DataFrame API
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on PR #37441:
URL: https://github.com/apache/spark/pull/37441#issuecomment-1214318488
I have also checked how they look using `bundle exec jekyll serve --host 0.0.0.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org