[GitHub] [spark] zhengruifeng commented on a change in pull request #35619: [FOLLOWUP][SPARK-36967][CORE] Report accurate shuffle block size if its skewed

[GitBox <gi...@apache.org>]

zhengruifeng commented on a change in pull request #35619:
URL: https://github.com/apache/spark/pull/35619#discussion_r813669582



##########
File path: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala
##########
@@ -265,7 +265,7 @@ private[spark] object HighlyCompressedMapStatus {
     val threshold =
       if (accurateBlockSkewedFactor > 0) {
         val sortedSizes = uncompressedSizes.sorted
-        val medianSize: Long = Utils.median(sortedSizes)
+        val medianSize: Long = Utils.median(sortedSizes, true)

Review comment:
       only in this call site `alreadySorted` is `true`, what about only changing this place to utilize the order?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org