You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Max Woghiren <ma...@chromium.org> on 2013/10/18 21:59:22 UTC
Review Request 14757: Cordova Plugin Registry Blog Post
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14757/
-----------------------------------------------------------
Review request for cordova.
Repository: cordova-site
Description
-------
A blog post outlining the basics of the Cordova plugin registry.
Diffs
-----
/README.md 1533594
/www/_posts/2013-10-21-cordova-registry.md PRE-CREATION
Diff: https://reviews.apache.org/r/14757/diff/
Testing
-------
Thanks,
Max Woghiren
Re: Review Request 14757: Cordova Plugin Registry Blog Post
Posted by Steven Gill <st...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14757/#review27202
-----------------------------------------------------------
Ship it!
Looks Great!
- Steven Gill
On Oct. 18, 2013, 7:59 p.m., Max Woghiren wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14757/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 7:59 p.m.)
>
>
> Review request for cordova.
>
>
> Repository: cordova-site
>
>
> Description
> -------
>
> A blog post outlining the basics of the Cordova plugin registry.
>
>
> Diffs
> -----
>
> /README.md 1533594
> /www/_posts/2013-10-21-cordova-registry.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14757/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Max Woghiren
>
>
Re: Review Request 14757: Cordova Plugin Registry Blog Post
Posted by Max Woghiren <ma...@chromium.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14757/#review27248
-----------------------------------------------------------
/www/_posts/2013-10-21-cordova-registry.md
<https://reviews.apache.org/r/14757/#comment53068>
Merged this line with the previous line.
I actually think I want to push back on aiming the post at app developers. If I were to change the audience to app developers, I'd remove the information on publishing plugins, since they don't care about that. A neutral audience makes sense.
Reworded the sentence; good point.
/www/_posts/2013-10-21-cordova-registry.md
<https://reviews.apache.org/r/14757/#comment53069>
No harm in having it there. It feels wrong to say "first, you need to create an account". Most of the time, that's false. :)
I changed the wording a bit, though, to make it a little less jarring.
/www/_posts/2013-10-21-cordova-registry.md
<https://reviews.apache.org/r/14757/#comment53071>
I've removed the unpublish mention. I don't know that I want to add too many details, but I changed it to "such as search for plugins by keyword". There's no preferred method of plugin searching.
/www/_posts/2013-10-21-cordova-registry.md
<https://reviews.apache.org/r/14757/#comment53074>
Changed "access" to "use".
- Max Woghiren
On Oct. 18, 2013, 7:59 p.m., Max Woghiren wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14757/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 7:59 p.m.)
>
>
> Review request for cordova.
>
>
> Repository: cordova-site
>
>
> Description
> -------
>
> A blog post outlining the basics of the Cordova plugin registry.
>
>
> Diffs
> -----
>
> /README.md 1533594
> /www/_posts/2013-10-21-cordova-registry.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14757/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Max Woghiren
>
>
Re: Review Request 14757: Cordova Plugin Registry Blog Post
Posted by Max Woghiren <ma...@chromium.org>.
> On Oct. 21, 2013, 3:13 p.m., Michal Mocny wrote:
> > /www/_posts/2013-10-21-cordova-registry.md, line 11
> > <https://reviews.apache.org/r/14757/diff/1/?file=366404#file366404line11>
> >
> > s/what plugins/which plugins/
I believe "what" is correct here. "Which" is for when you're picking from a set of items; "what" is used when the options to choose from aren't known.
- Max
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14757/#review27246
-----------------------------------------------------------
On Oct. 18, 2013, 7:59 p.m., Max Woghiren wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14757/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 7:59 p.m.)
>
>
> Review request for cordova.
>
>
> Repository: cordova-site
>
>
> Description
> -------
>
> A blog post outlining the basics of the Cordova plugin registry.
>
>
> Diffs
> -----
>
> /README.md 1533594
> /www/_posts/2013-10-21-cordova-registry.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14757/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Max Woghiren
>
>
Re: Review Request 14757: Cordova Plugin Registry Blog Post
Posted by Michal Mocny <mm...@chromium.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14757/#review27246
-----------------------------------------------------------
/www/_posts/2013-10-21-cordova-registry.md
<https://reviews.apache.org/r/14757/#comment53061>
s/what plugins/which plugins/
/www/_posts/2013-10-21-cordova-registry.md
<https://reviews.apache.org/r/14757/#comment53062>
Consider merging these two lines, and imho consider the reader an app developer instead of being abstract.
"Using the Cordova CLI, you can add plugins to your workspace with a single easy command:"
I wouldn't mention messy details (it badmouths the plugman flow, and sets up for a reply to say "hey I did blah with CLI and now I have messy details, you liar")
/www/_posts/2013-10-21-cordova-registry.md
<https://reviews.apache.org/r/14757/#comment53063>
"if you dont already have one" is implied.
/www/_posts/2013-10-21-cordova-registry.md
<https://reviews.apache.org/r/14757/#comment53064>
Not sure we need to call out unpublish, but search command is interesting. Is it prefered to use plugman to search, or to visit plugins.cordova.io? Is the list the same? Maybe expand on that.
/www/_posts/2013-10-21-cordova-registry.md
<https://reviews.apache.org/r/14757/#comment53065>
"app developers" -> "you", "their" -> "your", imho
"access" -> "use"
- Michal Mocny
On Oct. 18, 2013, 7:59 p.m., Max Woghiren wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14757/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 7:59 p.m.)
>
>
> Review request for cordova.
>
>
> Repository: cordova-site
>
>
> Description
> -------
>
> A blog post outlining the basics of the Cordova plugin registry.
>
>
> Diffs
> -----
>
> /README.md 1533594
> /www/_posts/2013-10-21-cordova-registry.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14757/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Max Woghiren
>
>
Re: Review Request 14757: Cordova Plugin Registry Blog Post
Posted by Anis Kadri <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14757/#review27201
-----------------------------------------------------------
Ship it!
Ship It!
- Anis Kadri
On Oct. 18, 2013, 7:59 p.m., Max Woghiren wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14757/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 7:59 p.m.)
>
>
> Review request for cordova.
>
>
> Repository: cordova-site
>
>
> Description
> -------
>
> A blog post outlining the basics of the Cordova plugin registry.
>
>
> Diffs
> -----
>
> /README.md 1533594
> /www/_posts/2013-10-21-cordova-registry.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14757/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Max Woghiren
>
>
Re: Review Request 14757: Cordova Plugin Registry Blog Post
Posted by Max Woghiren <ma...@chromium.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14757/
-----------------------------------------------------------
(Updated Oct. 21, 2013, 6:04 p.m.)
Review request for cordova.
Repository: cordova-site
Description
-------
A blog post outlining the basics of the Cordova plugin registry.
Diffs (updated)
-----
/README.md 1533594
/www/_posts/2013-10-21-cordova-registry.md PRE-CREATION
Diff: https://reviews.apache.org/r/14757/diff/
Testing
-------
Thanks,
Max Woghiren