You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by necouchman <gi...@git.apache.org> on 2017/10/13 17:13:58 UTC

[GitHub] incubator-guacamole-client pull request #199: GUACAMOLE-416: Add translation...

GitHub user necouchman opened a pull request:

    https://github.com/apache/incubator-guacamole-client/pull/199

    GUACAMOLE-416: Add translation entries for SQL Server module.

    Minor tweak to add missing entries for the SQL Server module to the base jdbc en.json file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/necouchman/incubator-guacamole-client GUACAMOLE-416

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-client/pull/199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #199
    
----
commit cc8ea75426b0fbdbc36a929e17ec20334506c085
Author: Nick Couchman <vn...@apache.org>
Date:   2017-10-13T17:13:12Z

    GUACAMOLE-416: Add translation entries for SQL Server module.

----


---

[GitHub] incubator-guacamole-client pull request #199: GUACAMOLE-416: Add translation...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-guacamole-client/pull/199


---

[GitHub] incubator-guacamole-client pull request #199: GUACAMOLE-416: Add translation...

Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/incubator-guacamole-client/pull/199#discussion_r146158333
  
    --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/resources/translations/en.json ---
    @@ -63,6 +63,14 @@
             "NAME" : "Shared Connections (PostgreSQL)"
         },
     
    +    "DATA_SOURCE_SQLSERVER" : {
    +        "NAME" : "SQL Server"
    +    },
    +
    +    "DATA_SOURCe_SQLSERVER_SHARED" : {
    --- End diff --
    
    I'm clearly late to the party, but that "e" should be uppercase. It will not match otherwise.


---