You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/08/01 06:05:43 UTC
[GitHub] zeppelin pull request #1256: [ ZEPPELIN-1259 ] create ace.editor configurati...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/1256
[ ZEPPELIN-1259 ] create ace.editor configuration manager service object
### What is this PR for?
https://github.com/apache/zeppelin/pull/1218
Establish a foundation to personalize the code editor settings.
Remove and set of ace.editor included in paragraph.controller.js.
### What type of PR is it?
Improve
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1259
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin dev/ZEPPELIN-1259
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1256.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1256
----
commit 912f1a0d48568d598cd16c9a1694255ae9f7c775
Author: CloverHearts <cl...@gmail.com>
Date: 2016-08-01T05:54:06Z
editor configuration in pargaraph.controller.js -> service object
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1256: [ ZEPPELIN-1259 ] create ace.editor configuration mana...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1256
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1256: [ ZEPPELIN-1259 ] create ace.editor configuration mana...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1256
@cloverhearts Sorry for the delay, I will take a look soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1256: [ ZEPPELIN-1259 ] create ace.editor configuration mana...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1256
This feature is not mergeable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1256: [ ZEPPELIN-1259 ] create ace.editor configuration mana...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1256
@corneadoug
please, can you review for this pr?
i divided to https://github.com/apache/zeppelin/pull/1218 pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1256: [ ZEPPELIN-1259 ] create ace.editor configuration mana...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1256
@corneadoug You're welcome, Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1256: [ ZEPPELIN-1259 ] create ace.editor configurati...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---